487406 - [Extension] Final localization string review

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Description

[Brian King [:kinger]]

Translators like notes, i.e. comments, in locale files for ambiguous strings.

As part of bug 486021, I added placeholders to all strings in bundles that have dynamic content, i.e. %S placeholders. These need to be filled out.

Other strings may also need notes, if there context tor meaning is not obvious to the casual translator.

Comment 1

[Justin Scott [:fligtar]]

I filled in the localization notes, but I noticed a few places where there are multiple %S in the same string. In PHP, we use numbers when this happens so that localizers can change the order of the sentence, like so:

The %1$S jumped over the charging %2$S.
The cat jumped over the charging dog.
The dog charged toward the jumping cat.

I'm not sure if this syntax works with JavaScript/extensions, but I suspect the localizers will need a way to change around each variable specifically.

Comment 2

[Justin Scott [:fligtar]]

Made some string changes and everything looks good to me now, so just need the variables differentiated.

Comment 3

[Brian King [:kinger]]

(In reply to comment #1)
> The %1$S jumped over the charging %2$S.

Found 2 strings, and changed them to this convention which is the same in string bundles. Revision 24439.

Comment 4

[Carsten Book [:Tomcat]]

verified