487733 - Error page site icon erroneously displayed sometimes when going Back

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Sam pointed this out to me today.

STR:

1) Open a new tab
2) Paste the URL in the URL field into the location bar, *delete the 'h' from 'http'* and press return.
3) Dismiss the sheet
4) Fix the URL; press return.
5) Change the '440' in the URL to '540'; press return.
6) Change the '540' to '640'; press return.
7) Press the back button to go back to the page you loaded in step 4.
8) Observe the site icon

ER: Blue globe site icon
AR: Error page site icon

This is perhaps some sort of edge-case that the logic introduced over time to fix bug 299807 doesn't handle?

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I've got a massive set of NSLogs for bug 425878; someone remind me to take a look at this bug using them and see if it tells us anything.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I can no longer reproduce this on the site in comment 0.  I've heard stories about this happening elsewhere, and I was able to track one down.

STR:

1) Load http://www.popoholic.com/bigimages/FP_5948690_BARM_BurkeHare_Premiere_102510.jpg
2) Change 1 character in the filename, e.g. '102510' to '102511', and press return
3) Reach site's 404 page; press Back button

ER: Blue globe site icon
AR: Error page site icon

I'm presuming this is the same thing that happened on the site in comment 0, but I can't be positive.

Based on the logging I used to investigate bug 425878, we're getting eRequestFailed in BrowserWrapper's updateSiteIconImage:withURI:status: (http://hg.mozilla.org/camino/annotate/7145c1e70720/src/browser/BrowserWrapper.mm#l1407) and handling that case appropriately.  The bug is that we shouldn't be getting eRequestFailed at all on the Back operation, and I don't know how to debug that.