299807 - little yellow triangle for Error Page favicon no longer shown

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Some time ago Simon fixed things so that when a site failed to load/error page
was displayed, we got a little yellow /!\ triangle as the favicon.

This no longer works; I'm not sure when it regressed :-(

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

OK, this regressed between June 27 (works) and June 28 (broken) nightlies for
windows/tabs that do not load your homepage when opening a new one of them.

*However*, you will *never* get the icon in any window/first tab if your
homepage is displayed when you load new tabs/windows--*unless* the page that is
set as your homepage is not found on startup.  As far as I can tell, this
*never* worked and you'll always see the globe (unless the favicon of the page
is cached; then you'll see it, which is even worse than seeing the globe rather
than the /!\)

If your homepage is displayed successfully on startup/creation of new
window/creation of new tab, any subsequent errors in [whatever container type
displays homepage] will always display the globe, even in the June 27 and prior
builds.  (If your homepage is an invalid/unreachable page, then you will see the
icon, but that won't be the case for most people.)

(Is the last pgh clear?  It's easy to demo but hard to explain.)

Can this be fixed (again) for 0.9?  I think it's an important piece of UI for
the successful adoption of error pages.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I think the regression part of this bug could have been Simon's fix for the
regression in bug 298291; cf. the original bug where the /!\ went in (I finally
found it), bug 295429.

An endless cycle of regressions? :-(

Comment 3

[Mike Pinkerton (not reading bugmail)]

any clues as to what broke this? packaging change in chrome?

Comment 4

[Simon Fraser [no longer active]]

I'll take a look.l Maybe we don't get an error status on the nsIRequest any more.

Comment 5

[Simon Fraser [no longer active]]

This broke because we're getting an onLocationChange for the error sheet, which
a good status.

Comment 6

[Simon Fraser [no longer active]]

Fixed by not changing the favicon for onLocationChange requests that don't have
an nsIRequest (like the error page load).

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

When the current page is a local page (local homepage or simply some random
file) and the next page fails to load, you don't get the little yellow triangle.

Not sure if this is worth reopening the bug for or not; I may be the only person
left in the world who uses a local homepage....

Comment 8

[Wevah (Nate Weaver)]

That should still be fixed, at any rate.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Reopening (again).  This regressed again in the August 1 build.  Could bug
302962 have regressed this (perhaps by way of bug 301666)?

P.S. Your favicon looked much nicer than the one we got from the core bug :-(

Comment 10

[Wevah (Nate Weaver)]

(In reply to comment #9)
> P.S. Your favicon looked much nicer than the one we got from the core bug :-(

Totally. The core one is ugly.

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Is this still broken again because bug 301119 hasn't been fixed to address
changes caused by "prettifying" (uglifying) error pages in bug 280190?

(Bug 301666 was filed to address comment 7, not the August breakage, in case
comment 9 is confusing...it confused me for a moment....)

Comment 12

[Simon Fraser [no longer active]]

Attachment: Patch (-w)

Comment 13

[Simon Fraser [no longer active]]

Fixed on trunk and branch.