488033 - newTagDialog.xul missing from messenger.jar 20090412

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.8) Gecko/2009032609 Firefox/3.0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b4pre) Gecko/20090412 Lightning/1.0pre Shredder/3.0b3pre

newTagDialog.xul is missing from messenger.jar

Reproducible: Always

Steps to Reproduce:
1. select a message
2. click Tag toolbar button
3. click "New tag"
OR
1. Tools > Options...
2. Display tab
3. Tags tab
4. Add button
Actual Results:  
Tiny window pops up with title "Page Load Er..."
Only two pixels height of content is visible, so unreadable.
However it is selectable, so ctrl-A ctrl-C (select all, copy) and pasting to an editor produces:

The file jar:file:///C:/.../chrome/messenger.jar!/content/messenger/newTagDialog.xul cannot be found. Please check the location and try again.

Expected Results:  
"Create new tag" dialog appears.

works in nightly 20090411
fails in nightly 20090412

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix

Turns out it's our UI alone, so it shouldn't have been living in mailnews/.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 372317 [details] [diff] [review]
Fix

Looks good! r=mkmelin

Comment 3

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/b1e1794e71fe

Comment 4

[Ludovic Hirlimann [:Usul]]

Philor would a good test-case for linux sound like
1. select a message
2. click Tag toolbar button
3. click "New tag"


and make sure that the tag is applied ?

Comment 5

[Phil Ringnalda (:philor)]

Probably not, since you're likely to need to rewrite that to "Customize the toolbar, drag the Tag button onto the toolbar" once the default set gets redone.

1. select message
2. right-click selected message
3. Tag > New Tag...
4. pick name and color
5. make sure the color appears in the threadpane, and the name and color appear in the envelope pane