Closed Bug 488533 Opened 11 years ago Closed 11 years ago

Tidy up the XUL in mailWindowOverlay.xul etc after Bug 413385 lands.

Categories

(SeaMonkey :: MailNews: Message Display, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b1

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file)

In Bug 413385 I really didn't want to refactor the child elements in the "mail-menubar" because this would involve massive whitespace changes and there were more than enough of these in the patch due to moving all the toolbar buttons into the palette. So I used a "bit of a cheat" as Neil calls it to avoid moving the whole menubar around in the XUL.

This is a followup tidy/reformat/whitespace bug to fix any remaining issues including the vastly inconsistent formatting of the child elements.
I'm going to morph this to also include bits of the following Thunderbird bugs that haven't made it to SeaMonkey MailNews yet:

Bug 412253 - Make it easier for extensions to overlay the TB mail toolbar by adding IDs
Bug 412252 - Make it easier for extensions to overlay the TB context-menus by adding IDs
changeset: 1186:292f87c7e59a - Add an id to the folder-pane's treecols, to allow for extensions, no bug, r=dmose
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Summary: Tidy up the XUL in "mail-menubar" in mailWindowOverlay.xul after Bug 413385 lands. → Tidy up the XUL in mailWindowOverlay.xul etc after Bug 413385 lands.
+        <menuseparator id="mailContext-sep-beforeAddNewTag"/>
         <menuitem id="mailContext-tagCustomize" 

"mailContext-sep-beforeAddNewTag" is incorrect since the menu item is customize tags instead of the Thunderbird "Add New Tag" menu item. But since the idea is to have the same overlay points as Thunderbird for extensions I'm not sure what to do here.

+<popupset id="mainPopupSet"/>

We don't need this but I've seen Thunderbird3 extensions start to hook into this. I expect to see more of this as more Firefox extensions are ported to Thunderbird.

Also, I've rearranged the order of the popups slightly to group the popups together.

-    <toolbar id="mail-toolbar-menubar2"/>
+    <toolbar id="mail-toolbar-menubar2">
+      <toolbaritem id="menubar-items">
+        <menubar id="mail-menubar"/>
+      </toolbaritem>
+    </toolbar>

Avoid nested overlay points at the expense of increased verbosity.
Attachment #375452 - Flags: superreview?(neil)
Attachment #375452 - Flags: review?(neil)
Attachment #375452 - Flags: superreview?(neil)
Attachment #375452 - Flags: superreview+
Attachment #375452 - Flags: review?(neil)
Attachment #375452 - Flags: review+
Keywords: checkin-needed
Comment on attachment 375452 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 3]


http://hg.mozilla.org/comm-central/rev/c0ffe05f3bd6
Attachment #375452 - Attachment description: Patch v1.0 → Patch v1.0 [Checkin: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b1
You need to log in before you can comment on or make changes to this bug.