488658 - test_brokenUTF-16.html failed on Solaris/SPARC

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ginn Chen]

42034 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/localstorage/test_brokenUTF-16.html | value result using broken key from getItem - got null, expected "a value"
42036 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/localstorage/test_brokenUTF-16.html | value result using broken key from [] - got null, expected "a value"

Reproducible on both mozilla-central and mozilla-1.9.1
Not reproducible on Solaris x86.

Comment 1

[Ginn Chen]

see bug 486654 comment #10

It seems it is an expected issue.
It just breaks more cases on SPARC.

Do we have a bug number for it?

Comment 2

[Honza Bambas (:mayhemer)]

It looks like there is not a bug for this, anyway, should be created. I hoped this was platform-independent issue because it's caused by some code in sqlite3. It converts a param before it's bind to a statement from utf16 to utf8, but no error is indicated when the string is corrupted, the string (key or a value) is screwed to something else and stored to database. Therefor there are todos in the tests. Aren't you using some other sqlite3 version? It's quit odd to me that when you store under a broken key you get null when trying to retrieve using that same key = there is no value stored under that key. I can say it's NOT an expect issue here.

Comment 3

[Ginn Chen]

I'm using the sqlite3 in mozilla-central source.

The broken UTF-16 test has 2 is() tests, and 3 todo_is() tests.
They're all failed on SPARC.

I think the string stored in DB is not null but something corrupted.
When we do "SELECT value, secure FROM webappstore2 WHERE scope = ?1 AND key = ?2", we get nothing,  therefore the result in javascript is null.

Perhaps the corrupted result is random on SPARC, so even we use the same broken key we still cannot get it.

Comment 4

[cajbir (:cajbir)]

Also failed on Windows NT:
42114 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/localstorage/test_brokenUTF-16.html | value result using broken key from getItem - got null, expected "a value"
42116 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/localstorage/test_brokenUTF-16.html | value result using broken key from [] - got null, expected "a value"
42114 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/localstorage/test_brokenUTF-16.html | value result using broken key from getItem - got null, expected "a value"
42116 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/localstorage/test_brokenUTF-16.html | value result using broken key from [] - got null, expected "a value"

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1245475800.1245480156.5559.gz&fulltext=1

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I filed bug 505708 on the random orange on Windows, which seems different from always-orange.

Comment 6

[Honza Bambas (:mayhemer)]

Ginn, after bug 524144 has landed, this should not be any longer failing. If you still experience it please let me know. Otherwise I'll close this bug.

Comment 7

[Ginn Chen]

Verified.