524144 - (SQLite3.6.20) Upgrade to SQLite 3.6.20

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Shawn Wilsher :sdwilsh]

It's not out yet, but when it's out, we'll need it!

Comment 1

[Honza Bambas (:mayhemer)]

Shawn, any estimation when they release? If it would be a longer time we should disable the failing test, it fails quit often and people frequently reference logs.

Comment 2

[Shawn Wilsher :sdwilsh]

I've been told by the SQLite developers that they want to figured out a top crash that we are seeing (bug 523405) and then it'll be a few days of testing before release.  So, sometime in November.

Comment 3

[Shawn Wilsher :sdwilsh]

Note that we'll be taking SQLite 3.6.16.1 on mozilla-central before this.  That is being tracked in bug 525539.

Comment 4

[Raúl Porcel]

Current sqlite included on mozilla-central has unaligned accesses, which looks like are fixed on 3.6.18.

Comment 5

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Mozilla changes for this.

Comment 6

[Shawn Wilsher :sdwilsh]

Pushed this to the try server to make sure all is well.

Comment 7

[Shawn Wilsher :sdwilsh]

Try server checked out OK.  Will push this to mozilla-central tomorrow.

Comment 8

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/302c19ec3301
http://hg.mozilla.org/mozilla-central/rev/bc3e54a0632b

Comment 9

[Shawn Wilsher :sdwilsh]

Comment on attachment 410336 [details] [diff] [review]
v1.0

This gets us stability fixes in SQLite, so I think we want this for 1.9.2.  It's also much nicer to the SQLite developers to say "hey, we are seeing this crash" and have code that isn't older than 6 months old.  This makes crash killing easier for them.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 410336 [details] [diff] [review]
v1.0

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.