Closed Bug 524144 (SQLite3.6.20) Opened 10 years ago Closed 10 years ago

Upgrade to SQLite 3.6.20

Categories

(Toolkit :: Storage, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

Details

Attachments

(1 file)

It's not out yet, but when it's out, we'll need it!
Shawn, any estimation when they release? If it would be a longer time we should disable the failing test, it fails quit often and people frequently reference logs.
I've been told by the SQLite developers that they want to figured out a top crash that we are seeing (bug 523405) and then it'll be a few days of testing before release.  So, sometime in November.
Note that we'll be taking SQLite 3.6.16.1 on mozilla-central before this.  That is being tracked in bug 525539.
Current sqlite included on mozilla-central has unaligned accesses, which looks like are fixed on 3.6.18.
Attached patch v1.0Splinter Review
Mozilla changes for this.
Pushed this to the try server to make sure all is well.
Whiteboard: [waiting on try-server results]
Try server checked out OK.  Will push this to mozilla-central tomorrow.
http://hg.mozilla.org/mozilla-central/rev/302c19ec3301
http://hg.mozilla.org/mozilla-central/rev/bc3e54a0632b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [waiting on try-server results]
Target Milestone: --- → mozilla1.9.3a1
Comment on attachment 410336 [details] [diff] [review]
v1.0

This gets us stability fixes in SQLite, so I think we want this for 1.9.2.  It's also much nicer to the SQLite developers to say "hey, we are seeing this crash" and have code that isn't older than 6 months old.  This makes crash killing easier for them.
Attachment #410336 - Flags: approval1.9.2?
Depends on: 527956
Blocks: 514291
Comment on attachment 410336 [details] [diff] [review]
v1.0

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.
Attachment #410336 - Flags: approval1.9.2?
Alias: SQLite3.6.20
You need to log in before you can comment on or make changes to this bug.