Closed Bug 488720 Opened 13 years ago Closed 13 years ago

Recurrence dialog doesn't work well when editing an event with monthly rule "The last day of the month"

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bv1578, Assigned: bv1578)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; it-IT; rv:1.9.0.8) Gecko/2009032609 Firefox/3.0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090415 Lightning/1.0pre090415 Shredder/3.0b3pre

Edit recurrence dialog allows to set an event with monthly rule "The last day of the month" but when you edit it, the dialog doesn't set properly all the controls and doesn't show the rule.

Reproducible: Always

Steps to Reproduce:
1. create a new event;
2. select repeat "custom";
3. select recurrence pattern "monthly" and "The last" + "Day of the month";
4. close the dialog;
5. click on the recurrence summary text displaying the recurrence rule

Actual Results:  
the edit recurrence dialog shows drop down menu (ordinal and weekday) disabled and daypicker enabled but without days selected i.e. no visual indication that the rule is "the last day of the month"

Expected Results:  
the dialog should show dropdown menu enabled with the options "The last" and "Day of the month" and daypicker should be disabled.

It doesn't work with Lightning 0.9 too but the result is different (the dialog shows "monthly" but the other controls belongs to daily rule).
Regression? This was already fixed with Bug 462048 for 1.0pre.
Attached patch patchSplinter Review
Seems that the code checks a BYDAY rule instead of a BYMONTHDAY rule.
The code has been added with attachment 303856 [details] [diff] [review] in bug 403594.
Attachment #373175 - Flags: review?(philipp)
Confirmed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090415 Lightning/1.0pre (20090415) Shredder/3.0b3pre.
Assignee: nobody → bv1578
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Windows XP → All
Hardware: x86 → All
Comment on attachment 373175 [details] [diff] [review]
patch

r=mschroeder. Thanks for the fix!
Attachment #373175 - Flags: review?(philipp) → review+
Whiteboard: checkin-needed
Keywords: checkin-needed
Whiteboard: checkin-needed
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/65c83e9fbd92>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.