48876 - D&D and modifier+click should be possible throughout the app

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect, P1)

Description

[Blake Ross]

Build ID: 2000081308

There's no way to reload, bookmark, save, view the source of, or pretty much do 
*anything* with Sidebar tabs. This could be easily solved with the addition of 
a limited context menu (which wouldn't include navigational items like Back and 
Forward).  I think the lack of Reload is the biggest killer here...how the heck 
do you manually reload the content?

Comment 1

[Matthew T (active 1999-2002)]

How about allowing the sidebar content to have (visible) focus, and then having 
all items in the main toolbar and menu bar (except for Back and Forward) 
operating on the sidebar content?

Comment 2

[Blake Ross]

works for me.  Ideas on showing visible focus?

Comment 3

[Matthew T (active 1999-2002)]

Showing a 1px black border around the inside of the sidebar content frame when it 
has focus. I think there's a bug asking to do the same thing to frames in the 
main content area, but it's been Futured. :-(

Comment 4

[Ben Bucksch (:BenB)]

> works for me.

Not for me. Clicking into a panel and hitting the reload button reload the main
browser window, not the panel.

blake's right - there's a lot of functionality in the browser that would be
necessary or at least useful in the sidebar. E.g. support for the title
attribute. Why can't we pretend, the sidebar panel were just another browser
window/frame (technically, this means using the navigator overlays, I think)?

Comment 5

[Ben Bucksch (:BenB)]

*** Bug 46276 has been marked as a duplicate of this bug. ***

Comment 6

[johng]

nav triage team:
cool ideas, some of this will be handled within the content (some folks adding
"refresh" to the content of web side tabs), but bottom line these are new
feature requests too late in the schedule so minus

Comment 7

[Ben Bucksch (:BenB)]

*** Bug 52008 has been marked as a duplicate of this bug. ***

Comment 8

[Blake Ross]

reassigning to matt

Comment 9

[Ben Bucksch (:BenB)]

Nominating for mozilla0.9. This bug is very annoying during sidebar development
and usage. It would also fix a whole bunch of other existing bugs (I saw at
least 5 or so).

Comment 10

[Blake Ross]

reassigning to me.  I have a bunch of fixes for sidebar selection, d&d, context 
menus, modifier- and middle-click handling, and more.

Comment 11

[Ben Bucksch (:BenB)]

blake, can't we just reuse the browser functions?

Comment 12

[Blake Ross]

Ben, which part of my comment suggested that I wasn't?

But there are many changes that need to be made.  The sidebar is in other apps 
besides the browser, and not all of those apps have access to browser functions.

Comment 13

[Ben Bucksch (:BenB)]

> which part of my comment suggested that I wasn't?

but

> and not all of those apps have access to browser functions

I'm confused.

Comment 14

[Blake Ross]

I am reusing already-written browser functions, but generalizing them so they 
can be used in other places besides the browser.

Comment 15

[Ben Bucksch (:BenB)]

Oh, cool. (I thought, they were already in this state.)

Comment 16

[Blake Ross]

Attachment: Part 1: implement modifier-/middle-click handling and d&d everywhere

Comment 17

[Blake Ross]

Attached a fix which also includes the partial patch for bug 50673 (cause it 
goes along with this).  This fix implements d&d in the sidebar and in mail 
messages.  It also allows for the standard modifier+click and middle-click 
handling in the personal toolbar, mail messages, sidebar, etc.  I'll attach 
more patches soon for sidebar context menus.  Meanwhile, I found out that you 
can in fact select text in the sidebar (because you can drag and then copy), 
but the selection itself isn't painted.  I'm still trying to figure out why 
this is.

Asking alecf to do some review here...

Comment 18

[Ben Bucksch (:BenB)]

blake, this rocks. I missed middle-click and d&d in mailnews msgs.

For new files, shouldn't you name yourself, not Netscape, as "Inital Developer",
even if you copied some functions from existing files?

Comment 19

[Blake Ross]

Attachment: new patch (part 1)

Comment 20

[Blake Ross]

This new patch fixes (partially) d&d to compose attachment tree and d&d into 
view source window also (there're separate bugs on those).

Comment 21

[Ben Bucksch (:BenB)]

[e-mail] changed:
           What    |Old Value                   |New Value
----------------------------------------------------------------------------
            Summary|Sidebar tab webpages have   |D&D and modifier+click
                   |little (almost no)          |should be possible
                   |functionality               |throughout the app

(It's worth to log that here, since it is a drastic change in scope.)

> d&d to compose attachment tree

Cool. Does it also work for msgs? I.e. can I attach a msg (like it would if I
|ForwardAsAttachment|) by dragging it from the thread pane to the attachment
area, like I could in 4.x Unix?

Comment 22

[Blake Ross]

> It's worth to log that here, since it is a drastic change in scope.

Yeah.  I haven't really decided what I'm going to do re: the original bug.  
Since I kinda changed it.

Sorry, no, that message dragging doesn't work yet.  But I haven't even looked 
into it yet.  I suspect it's not all that hard.

Comment 23

[Ben Bucksch (:BenB)]

> message dragging

IIRC, it is the only way to forward more than one msg at once, so it would be
really useful(TM).

Comment 24

[Blake Ross]

alec, don't review just yet.  I'll attach a new patch tomorrow with suggestions 
from jag.

Comment 25

[Alec Flett]

This is great blake, but a few comments:
- first, let's not make this "nodeclick.js" - lets make it "contentAreaUtils.js"
or something - since this is basically for any kind of app that has a gecko
content area.
- second, I see at least one place where oncommand= became onclick= - oncommand=
is the correct one - onclick just handles mouseclicks, oncommand handles
keyboard activation as well.

Comment 26

[Blake Ross]

> - first, let's not make this "nodeclick.js" - lets make 
> it "contentAreaUtils.js" or something - since this is basically for any kind 
> of app that has a gecko content area.

hmm, okay.  although it really is only for clicks, and nodeDD is for d&d...

> - second, I see at least one place where oncommand= became onclick= - 
> oncommand= is the correct one - onclick just handles mouseclicks, oncommand 
> handles keyboard activation as well.

The only place I changed this was for the personal toolbar items, so that we 
could get an event.button and handle middle click (oncommand is left click 
only, apparently).  This should be fine, since toolbar buttons/items shouldn't 
take focus or be accessible via the keyboard...

Comment 27

[Blake Ross]

Just to be clear: the click-handling and dnd-handling are in two separate files 
right now, nodeClick.js and nodeDD.js.  I was thinking of putting them together 
(since right now I'm including both of them wherever they're used), but jag 
suggested breaking them apart.

Comment 28

[Blake Ross]

thought about it a little more.  I guess something like contentAreaUtils.js is 
pretty good, since the file does include other stuff (openNewWindowWith(), 
savePage(), etc)

Comment 29

[Blake Ross]

Attachment: revised patch

Comment 30

[Blake Ross]

Modified and middle click doesn't work on PT items in the new fix while alec, 
jag and I work out the best way to do it.

[note to self: make clicks on home work also once we decide on a way]

Comment 31

[Blake Ross]

Attachment: slightly revised for whitespace and another minor fix

Comment 32

[Peter "jag" Annema]

r=jag

Thanks for making my life merge hell soon ;-) (Poor shaver)

Comment 33

[Blake Ross]

OK, part 1 checked in.  I know this bug got heavily morphed, but I really 
reported it too generally to begin with.  I'll file separate bugs for the 
selection and context menu problems, and start making fixes for those tomorrow.

Comment 34

[Jesse Ruderman]

Blake, I can't copy selections from some sidebar panels at all (bug 52010).  
What panel allows you to select&copy but doesn't show you the selection?

Comment 35

[Matthew T (active 1999-2002)]

Blake, what are the bug numbers for those other bugs -- the lack of selection, 
the lack of context menus, and the inability to use {Back, Forward, Reload, view 
source, Use Style, etc} in a sidebar panel?

Comment 36

[Matthew T (active 1999-2002)]

Lack of context menus is bug 18787 ...

Comment 37

[Blake Ross]

Selection problem is bug 60988.

Comment 38

[shrirang khanzode]

over to sujay

Comment 39

[sujay]

okay Reload is in the context menu....and I think it works....
Blake can y ou double check and see if its working...