Closed
Bug 488943
Opened 16 years ago
Closed 16 years ago
The "Private" checkbox is meaningless to new users
Categories
(Bugzilla :: User Interface, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.6
People
(Reporter: mkanat, Assigned: mkanat)
References
Details
(Keywords: ue)
Attachments
(1 file, 1 obsolete file)
|
5.32 KB,
patch
|
guy.pyrzak
:
review+
LpSolit
:
review+
|
Details | Diff | Splinter Review |
Pyrzak's students' research points out:
Private could mean that only the submitter sees the description or that only people assigned to work on the bug can see it, or something else entirely. There’s no help to explain the implications of making a description private.
Comment 1•16 years ago
|
||
Would a tooltip help? I'm not sure "Confidential" would be a better name.
| Assignee | ||
Comment 2•16 years ago
|
||
Okay, this fixes it everywhere except bug/comments.html.tmpl. I didn't change the word "Private" there because we need to use minimal UI space. I considered just putting the name of the insidergroup there instead--do you think that would be better?
| Assignee | ||
Updated•16 years ago
|
Blocks: bz-hci2008
Comment 3•16 years ago
|
||
Comment on attachment 373423 [details] [diff] [review]
v1
it's the right start, but I'd like to let people know that on the comments that it will be marked as private if they check the box or somethign like that. i don't think it needs to be wordy, maybe just say (private) after the text you already have if that makes sense. That way uses might learn what private means.
Attachment #373423 -
Flags: review?(guy.pyrzak) → review-
| Assignee | ||
Comment 4•16 years ago
|
||
Oh, good idea! How about this?
Attachment #373423 -
Attachment is obsolete: true
Attachment #379032 -
Flags: review?(guy.pyrzak)
Updated•16 years ago
|
Attachment #379032 -
Flags: review?(guy.pyrzak)
Attachment #379032 -
Flags: review?(LpSolit)
Attachment #379032 -
Flags: review+
Comment 5•16 years ago
|
||
Comment on attachment 379032 [details] [diff] [review]
v2
looks good. Although my runtests.sh failed (but not caused by anything in this code). I'd prefer not to use <br>'s to do new lines (css is better) but since it is already used all over I'm guessing that's another bug.
Updated•16 years ago
|
Attachment #379032 -
Flags: review?(LpSolit) → review+
Comment 6•16 years ago
|
||
Comment on attachment 379032 [details] [diff] [review]
v2
>Index: template/en/default/attachment/edit.html.tmpl
>+ <label for="isprivate">private (only visible to
>+ <strong>[% Param('insidergroup') FILTER html %]</strong>)
>+ </label>
For consistency with other places, the sentence should be "... to the foo group". Please fix that on checkin. r=LpSolit
Updated•16 years ago
|
Flags: approval+
| Assignee | ||
Comment 7•16 years ago
|
||
(In reply to comment #6)
> For consistency with other places, the sentence should be "... to the foo
> group". Please fix that on checkin. r=LpSolit
That's too long to fit well in the UI there.
Comment 8•16 years ago
|
||
(In reply to comment #7)
> That's too long to fit well in the UI there.
There is a plenty of place. The requestee field for attachment flags already takes some place. And in the worst case, the text will wrap.
| Assignee | ||
Comment 9•16 years ago
|
||
Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v <-- create.html.tmpl
new revision: 1.40; previous revision: 1.39
done
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v <-- edit.html.tmpl
new revision: 1.60; previous revision: 1.59
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v <-- edit.html.tmpl
new revision: 1.158; previous revision: 1.157
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v <-- create.html.tmpl
new revision: 1.94; previous revision: 1.93
done
Checking in template/en/default/list/edit-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v <-- edit-multiple.html.tmpl
new revision: 1.56; previous revision: 1.55
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•