488955 - iCCP PNG images render as white or incorrect colored square.

Status: VERIFIED FIXED

(Core :: Graphics: Color Management, defect, P1)

Description

[philippe (part-time)]

Attachment: screenshot

test case: http://libpng.org/pub/png/colorcube/colorcube-pngs-iCCP-CSS.html

AR: Most image squares are blank, some colors display correctly, some barely look like the surrounding background color

ER: color of images match the background color (css).

This is a regression from bug 481926.

gfx.color_management.mode set to 1 or 2 (default).

Gecko 1.9.0.x with color management turned on rendered this correctly

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090417 Minefield/3.6a1pre

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090417 Minefield/3.6a1pre

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Do we need to fix this for b4? How many sites is it likely to affect?

Comment 2

[philippe (part-time)]

(In reply to comment #1)
> Do we need to fix this for b4? How many sites is it likely to affect?

Probably not many 'real world' websites. Experimental sites, who knows.
It would be good to have this kind of thing fixed before final though.  The page used to display correctly.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Fix generation of linear gamma input tables

Comment 4

[Joe Drew (not getting mail)]

Comment on attachment 373662 [details] [diff] [review]
Fix generation of linear gamma input tables

r+ as long as we commit a reftest along with this fix.

Comment 5

[Joe Drew (not getting mail)]

http://hg.mozilla.org/mozilla-central/rev/c4264cf03c96

Comment 6

[Joe Drew (not getting mail)]

(reftest is in bug 489133)

Comment 7

[Joe Drew (not getting mail)]

Comment on attachment 373662 [details] [diff] [review]
Fix generation of linear gamma input tables

This patch now has tests, and is very low risk.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 373662 [details] [diff] [review]
Fix generation of linear gamma input tables

a191=beltzner

Comment 9

[Joe Drew (not getting mail)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/486b76052a94

Comment 10

[Aakash Desai [:aakashd]]

verified FIXED on builds: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090507 Minefield/3.6a1pre ID:20090507032833

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090507 Shiretoko/3.5b5pre ID:20090507034334