PNGs on the web with bogus cHRM chunks display as all black (silhouette)

VERIFIED FIXED

Status

()

defect
P2
normal
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: phiw2, Assigned: jrmuizel)

Tracking

({regression, verified1.9.1})

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9.1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

This was originally uncovered (and fixed for Shiretoko 3.1b3) in bug 460520.
Bug 481926 undid/broke this.

Since bug 481926, all color information in those images is lost; they display as black silhouettes. In Shiretoko 3.1b3 the images display correctly

testcases: 
https://bugzilla.mozilla.org/attachment.cgi?id=343609
https://bugzilla.mozilla.org/attachment.cgi?id=343611
(linked in bug 460520); those are images from real websites.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090419 Minefield/3.6a1pre

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20090418 Minefield/3.6a1pre
Flags: wanted1.9.1?
Flags: blocking1.9.1?
Comment on attachment 373663 [details] [diff] [review]
have set_rgb_colorants return whether it succeeded or not

r+ as long as we check in a reftest along with this fix.
Attachment #373663 - Flags: review?(joe) → review+
Flags: wanted1.9.1?
Flags: blocking1.9.1?
Flags: blocking1.9.1+
Priority: -- → P2
This fixes another one of the pngs with a bad cHRM chunk
Tests for bugs 460520, 489133 and 488955
Attachment #373921 - Flags: review?(joe)
Attachment #373920 - Flags: review?(joe)
Actually get the reftests running
Attachment #373921 - Attachment is obsolete: true
Attachment #373934 - Flags: review?(joe)
Attachment #373921 - Flags: review?(joe)
Attachment #373920 - Flags: review?(joe) → review+
Attachment #373934 - Flags: review?(joe) → review+
I probably should've let you know but the patch from bug 488955 needs to be applied before that test will pass :)
Assignee: nobody → jmuizelaar
Attachment #373663 - Flags: approval1.9.1?
Attachment #373920 - Flags: approval1.9.1?
Keywords: checkin-needed
Whiteboard: [c-n for 1.9.1]
Attachment #373663 - Flags: approval1.9.1?
Attachment #373920 - Flags: approval1.9.1?
Verified FIXED on builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090527 Minefield/3.6a1pre ID:20090527031500

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090527 Shiretoko/3.5pre ID:20090527031214
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.