488972 - Help Key [F1] does not work in the pageInfo window.

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Philip Chee]

Steps to reproduce:
1. Invoke the Page Info window.
2. Press F1
See error: doHelpButton() is not defined.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Port Firefox doHelpButton() to Suite.

This is a cut and paste port of the doHelpButton() function from the Firefox Page Info.

Comment 2

[[e-mail]]

Comment on attachment 373463 [details] [diff] [review]
Patch v1.0 Port Firefox doHelpButton() to Suite.

>+    "feedTab":     "pageinfo_general", //"pageinfo_feed",
>+    "permTab":     "pageinfo_general", //"pageinfo_permissions",
Are there bugs on these?

Comment 3

[Philip Chee]

>>+    "feedTab":     "pageinfo_general", //"pageinfo_feed",
>>+    "permTab":     "pageinfo_general", //"pageinfo_permissions",
> Are there bugs on these?

Yes. Bug 397236 is for update of Page Info. Bug 423281 is the tracking bug.

Comment 4

[Stefan [:stefanh]]

It'd be nice if mac users could open pageInfo help from the keyboard too.

Comment 5

[[e-mail]]

Comment on attachment 373463 [details] [diff] [review]
Patch v1.0 Port Firefox doHelpButton() to Suite.

I was thinking you could use "pageinfo_" + id.slice(0, -3) but I guess that doesn't work nicely with overlays.

>+    "feedTab":     "pageinfo_general", //"pageinfo_feed",
>+    "permTab":     "pageinfo_general", //"pageinfo_permissions",
We've got a default value so you can just comment out the whole line but using the intended help topic name.

>+  var helpdoc = helpTopics[tabbox.selectedTab.id] || "pageinfo_general";
Maybe the default should be "nav-page-info"?

Comment 6

[Philip Chee]

Attachment: Patch v1.1 Fix nits [for checkin]

Carrying forward r+/sr+ from Neil.

> (From update of attachment 373463 [details] [diff] [review])
>>+    "feedTab":     "pageinfo_general", //"pageinfo_feed",
>>+    "permTab":     "pageinfo_general", //"pageinfo_permissions",
> We've got a default value so you can just comment out the whole line but using
> the intended help topic name.
Fixed.

>>+  var helpdoc = helpTopics[tabbox.selectedTab.id] || "pageinfo_general";
> Maybe the default should be "nav-page-info"?
Fixed.

Comment 7

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/5861fd223d15