488983 - 2 * |mailnews/base/src/nsMsgGroupThread.cpp(...) : warning C4018: '>=' : signed/unsigned mismatch|

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090417 SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/9e06217fc471
 +http://hg.mozilla.org/comm-central/rev/...)

{
mailnews/base/src/nsMsgGroupThread.cpp(238) : warning C4018: '>=' : signed/unsigned mismatch
mailnews/base/src/nsMsgGroupThread.cpp(246) : warning C4018: '>=' : signed/unsigned mismatch
}

Code is
{
NS_IMETHODIMP nsMsgGroupThread::GetChildKeyAt(PRInt32 aIndex, nsMsgKey *aResult)
NS_IMETHODIMP nsMsgGroupThread::GetChildAt(PRInt32 aIndex, nsIMsgDBHdr **aResult)
}
But aIndex "should" be PRUint32.

+/- related to bug 488982.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Remove an unused 'threadParent' [Checkin: Comment 3]

Fixes |mailnews/base/src/nsMsgGroupThread.cpp(281) : warning C4101: 'threadParent' : unreferenced local variable|.

Comment 2

[David :Bienvenu]

Comment on attachment 373477 [details] [diff] [review]
(Av1) Remove an unused 'threadParent'
[Checkin: Comment 3]

thx for the patch.

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 373477 [details] [diff] [review]
(Av1) Remove an unused 'threadParent'
[Checkin: Comment 3]


http://hg.mozilla.org/comm-central/rev/be32f5cc0c58