489001 - archive is not disabled for .eml files (which is should be until it can work)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

The Message | "Archive" command is not properly disabled for .eml files, e.g. opened from file or coming in as mail attachments.

Comment 1

[Thomas D. (:thomas8)]

I have posted bug 516240 to request the opposite: archive command should work because imo the user should be allowed to archive such mails if he so pleases. There might be 1001 legitimate reasons why user wants to archive some external mail.

Comment 2

[Magnus Melin [:mkmelin]]

Well bug 516240 is the reason this is a bug.
And bug 516240 should be duped to the bug about being able to save .emls to folders - which is a real old one.

Comment 3

[Thomas D. (:thomas8)]

(In reply to comment #2)

Magnus, I don't understand well.
Currently the archive command is enabled, but it doesn't work.
In this bug 489001 you want to disable the archive command, so we can't use it any more.
In my bug 516240 I want to keep it enabled, and make it work (which is the opposite of your request).

> Well bug 516240 is the reason this is a bug.

If my bug (it doesn't work right now) is the reason for your bug (therefore it should be disabled), then maybe we can agree that in the long run, making it work and then re-enabling it would be the best choice?
In other words, are you suggesting to disable the command only until we get it to work or do you think disabling archive command for .eml files should be the final solution? If the latter, why? Otherwise, I suggest that we rephrase the summary of this bug to point out its temporary workaround nature:

"Message > Archive command should be disabled for .eml files until it works"

> And bug 516240 should be duped to the bug about being able to save .emls to
> folders - which is a real old one.

You are right, it is very similar to 6-year-old Bug 193281 with 51 votes (Ability to import e-mail messages from .eml text files to folders (Message|Copy)). Whereas Bug 193281 focusses on the Message > Copy command, my bug 516240 is specifically about the Message > Archive command. If it's clear and we agree that archive command should be enabled, I don't mind duplicating 516240 against 193281. Maybe better solution is to make my bug 516240 dependent on 193281.

Comment 4

[Magnus Melin [:mkmelin]]

Yes this bug is only meant to disable archive until it could work.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 401708 [details] [diff] [review]
proposed fix

I agree, disabling archive on .eml files until it will work is a good idea. r+a=Standard8

Comment 7

[Magnus Melin [:mkmelin]]

changeset:   3865:cab7d59e3f1e
http://hg.mozilla.org/comm-central/rev/cab7d59e3f1e

->FIXED