folder operations are shown/enabled in .eml context menu

VERIFIED FIXED in Thunderbird 3.0b3

Status

VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: mkmelin, Assigned: mkmelin)

Tracking

Trunk
Thunderbird 3.0b3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 373499 [details] [diff] [review]
proposed fix

Folder operations are not properly disabled/hidden for the context menu of .eml files.

Copy
Move
Copy/move again
Tag
Mark
Delte

... should all be hidden since they can't do anything.
Attachment #373499 - Flags: review?(jminta)

Comment 1

10 years ago
Comment on attachment 373499 [details] [diff] [review]
proposed fix

+  ShowMenuItem("mailContext-delete", !hideMailItems && msgFolder);
Does this actually want to be && canMove so that we check msgFolder.canDeleteMessages?
Attachment #373499 - Flags: review?(jminta) → review+
(Assignee)

Comment 2

10 years ago
Good catch! Though actually, (isNewsgroup || canMove) since it's "Cancel message" on ngs.

changeset:   2427:030ba3fa4533
http://hg.mozilla.org/comm-central/rev/030ba3fa4533

->FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 3

10 years ago
V (on WinXP 64) with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.1b5pre) Gecko/20090425 Shredder/3.0b3pre

Thanks, Magnus.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.