trying to copy/move .eml to folder crashes @nsMsgSearchDBView::ProcessRequestsInOneFolder

VERIFIED FIXED in Thunderbird 3.0b3

Status

--
critical
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: mkmelin+mozilla, Assigned: mkmelin+mozilla)

Tracking

Trunk
Thunderbird 3.0b3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 373505 [details] [diff] [review]
proposed fix

For .eml files the Copy option in the context is still there (bug 489005). Clicking it will crash.

http://crash-stats.mozilla.com/report/index/eae1e8a5-dccc-424a-
8cf7-83b992090418?p=1

Since extensions (and bugs in our js code) can easily get here, we shouldn't crash.
Attachment #373505 - Flags: superreview?(bugzilla)
Attachment #373505 - Flags: review?(bugzilla)
Comment on attachment 373505 [details] [diff] [review]
proposed fix

>+
>+  if (!m_folder)
>+    return NS_ERROR_FAILURE;
>+

I think NS_ERROR_NOT_INITIALIZED would be a clearer result here. r/sr=Standard8 with that fixed.
Attachment #373505 - Flags: superreview?(bugzilla)
Attachment #373505 - Flags: superreview+
Attachment #373505 - Flags: review?(bugzilla)
Attachment #373505 - Flags: review+
(Assignee)

Comment 3

10 years ago
changeset:   2426:a27f5e08a03c
http://hg.mozilla.org/comm-central/rev/a27f5e08a03c

->FIXED
Status: NEW → RESOLVED
Last Resolved: 10 years ago
OS: Linux → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
(Assignee)

Updated

9 years ago
Depends on: 491016

Comment 4

9 years ago
Jay, care to verify this and mark appropriately?
(fixed severity)
Severity: normal → critical
I do not have a "Copy" option for .eml attachments in my context menu. Verifying Fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.