489011 - trying to copy/move .eml to folder crashes @nsMsgSearchDBView::ProcessRequestsInOneFolder

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[Magnus Melin [:mkmelin] (away, back June 30)]

Attachment: proposed fix

For .eml files the Copy option in the context is still there (bug 489005). Clicking it will crash.

http://crash-stats.mozilla.com/report/index/eae1e8a5-dccc-424a-
8cf7-83b992090418?p=1

Since extensions (and bugs in our js code) can easily get here, we shouldn't crash.

Comment 1

[Mark Banner (:standard8)]

(In reply to comment #0)
> http://crash-stats.mozilla.com/report/index/eae1e8a5-dccc-424a-
> 8cf7-83b992090418?p=1

bp-eae1e8a5-dccc-424a-8cf7-83b992090418

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 373505 [details] [diff] [review]
proposed fix

>+
>+  if (!m_folder)
>+    return NS_ERROR_FAILURE;
>+

I think NS_ERROR_NOT_INITIALIZED would be a clearer result here. r/sr=Standard8 with that fixed.

Comment 3

[Magnus Melin [:mkmelin] (away, back June 30)]

changeset:   2426:a27f5e08a03c
http://hg.mozilla.org/comm-central/rev/a27f5e08a03c

->FIXED

Comment 4

[Wayne Mery (:wsmwk)]

Jay, care to verify this and mark appropriately?
(fixed severity)

Comment 5

[Jay Moran (jaym/lazvon)]

I do not have a "Copy" option for .eml attachments in my context menu. Verifying Fixed.