489106 - Not opening drafts as drafts from saved searches

Status: NEW

(Thunderbird :: Mail Window Front End, defect)

Description

[klonos]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090417 Minefield/3.6a1pre (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090404 Lightning/1.0pre Shredder/3.1a1pre ID:20090415050013

Double-clicking on an draft email while still in the 'Drafts' special folder opens the mail in edit mode as expected.

Double-clicking on that very same mail from a search or a saved search folder opens it in reading mode and one has to take an extra action to edit & send.

Reproducible: Always

Steps to Reproduce:
1. Start composing a new mail.
2. Close the compose window before you send the email.
3. When asked if you want to save the unsent mail or not, say yes.
4. Once it is saved switch to the 'Drafts' folder (if not there already).
5. Double-click the mail you've just saved.
6. (Mail opens in edit mode) Close the window again without sending the mail.
7. Start a search (Edit -> Find -> Search Messages... or Ctrl-Shift+F in Windows).
8. Enter some criteria that'll select the unsent mail.
9. Click on 'Search' and once you can see the above mentioned mail, either double click it or save the search as a search folder, navigate to it and double click the mail from there.
(mail opens in view/read mode)

Actual Results:  
Draft mail opened from search open in view/read mode.


Expected Results:  
Draft mail opened from search should open in compose mode.

Comment 1

[Magnus Melin [:mkmelin]]

ThreadPaneDoubleClick() should probably check gDBView.hdrForFirstSelectedMessage.folder instead of gDBView.msgFolder

http://mxr.mozilla.org/comm-central/source/mail/base/content/threadPane.js#223
http://mxr.mozilla.org/comm-central/source/mail/base/content/msgHdrViewOverlay.js#1865

Comment 2

[Mina]

Attachment: a patch folder explaining how the BUG could be fixed :)

Comment 3

[Mina]

Attachment: Bug fixing :)

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 413340 [details] [diff] [review]
Bug fixing :)

No sr required for mail/ only code.

First, the patch doesn't apply cleanly.

No tabs please, mozilla style is (preferably two) space indention.

Most (all?) of the initializations you do should not be necessary. They are already initialized around http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindow.js#129

>             MsgOpenSelectedMessages();
>+	    //MsgComposeDraftMessage();

No point adding a commented out line.

>-        msgComposeService.OpenComposeWindow(null, hdr, messageUri, type, format, identity, msgWindow);
>+        msgComposeService.OpenComposeWindow(null, null, messageUri, 9, 0, null, null);

No magic numbers please.


>+	//this part was added as a response to  Bug 489106 https://bugzilla.mozilla.org/show_bug.cgi?id=489106,
>+	// the bug was solved as a part from the German University in 

We don't add this kind of info as code comments, hg blame + bug comments should be enough.


All in all i'm not convinced this is correct approach... but it's hard to tell at this stage of the patch.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 413337 [details] [diff] [review]
a patch folder explaining how the BUG could be fixed :)

Cancelling review request on obsolete patch that was updated.

Comment 6

[klonos]

Using tb 3.2a1pre and more than a whole year after reporting it, this bug is still there :(

Comment 7

[Wayne Mery (:wsmwk)]

but works in unified folders.  isn't unified a special saved search?

Comment 8

[David :Bienvenu]

Unified is a special saved search, yes, but it's the specialness that's the distinction, i.e., the unified drafts folder has the draft folder flag set on the folder.

Comment 9

[Wayne Mery (:wsmwk)]

Mina is no longer working on the patch

Comment 10

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Comment on attachment 413340 [details] [diff] [review]
Bug fixing :)

Obsolete due to r-, but the patch seems to mostly apply.

$ patch -p1 --dry-run < ~/Desktop/p489106.diff 
patching file mail/base/content/SearchDialog.js
patching file mail/base/content/folderDisplay.js
Hunk #1 succeeded at 276 (offset 63 lines).
patching file mail/base/content/mailCommands.js
Hunk #2 succeeded at 231 (offset 37 lines).
Hunk #3 succeeded at 289 (offset 37 lines).
patching file mail/base/content/mailWindowOverlay.js
Reversed (or previously applied) patch detected!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
3 out of 3 hunks ignored -- saving rejects to file mail/base/content/mailWindowOverlay.js.rej
patching file mail/base/content/threadPane.js