Closed Bug 489204 Opened 15 years ago Closed 15 years ago

context menus shouldn't show at all when nothing is selected

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: mkmelin, Assigned: mkmelin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch proposed fix (obsolete) — Splinter Review
Testing the context menus some more, I notice when no message is selected and you select msg body, or click the thread header (oh... bug 433039) the context menu show, but the menu item (Tag) that are enabled doesn't do anything useful. Better not show any context menu at all - there's nothing to do.

Clicking the thread pane header will (also) currently give us a
Error: treeBoxObj is undefined
Source File: chrome://messenger/content/msgMail3PaneWindow.js
Line: 1131
Attachment #373702 - Flags: review?(jminta)
Attachment #373702 - Flags: review?(jminta) → review?(philringnalda)
Somebody (can't imagine who) seems to have given you a nasty case of bitrot in fillMailContextMenu().
Attached patch proposed fix, v2Splinter Review
Unbitrotted.
Attachment #373702 - Attachment is obsolete: true
Attachment #377458 - Flags: review?(philringnalda)
Attachment #373702 - Flags: review?(philringnalda)
Attachment #377458 - Flags: review?(philringnalda) → review+
changeset:   2660:55dce6918155
http://hg.mozilla.org/comm-central/rev/55dce6918155

->FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Blocks: TB2SM
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: