Closed Bug 489273 Opened 16 years ago Closed 16 years ago

debug libxul build broken

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: hiro, Assigned: benjamin)

References

Details

Attachments

(3 files, 1 obsolete file)

Sprinkle -NODEFAULTLIB around xpt-land, rev. 1
483 bytes, patch
ted
: review+
Details | Diff | Splinter Review
A patch
553 bytes, patch
benjamin
: review-
Details | Diff | Splinter Review
Use -Zl like the glue makefile
383 bytes, patch
benjamin
: review+
Details | Diff | Splinter Review
make[1]: Entering directory `/c/cygwin/home/user/hg/mozilla-central/objdir-winx -dbg/xulrunner/toolkit/library' c:/mozilla-build/moztools/bin/nsinstall.exe /c/cygwin/home/user/hg/mozilla-cent al/rdf/util/src/nsRDFResource.cpp /c/cygwin/home/user/hg/mozilla-central/intl/u icharutil/util/nsUnicharUtils.cpp /c/cygwin/home/user/hg/mozilla-central/intl/u icharutil/util/nsCompressedCharMap.cpp /c/cygwin/home/user/hg/mozilla-central/i tl/unicharutil/util/nsBidiUtils.cpp . make[1]: Leaving directory `/c/cygwin/home/user/hg/mozilla-central/objdir-winxp dbg/xulrunner/toolkit/library' make libs make[1]: Entering directory `/c/cygwin/home/user/hg/mozilla-central/objdir-winx -dbg/xulrunner/toolkit/library' link -NOLOGO -DLL -OUT:xul.dll -PDB:xul.pdb -SUBSYSTEM:WINDOWS dlldeps-xul.obj nsStaticXULComponents.obj nsDllMain.obj dlldeps.obj nsGFXDeps.obj dlldeps-zlib. bj nsUnicharUtils.obj nsCompressedCharMap.obj nsBidiUtils.obj nsRDFResource.obj ./module.res -MANIFESTUAC:NO -NXCOMPAT -SAFESEH -DYNAMICBASE -DEBUG -DEBUGT PE:CV ../../toolkit/xre/xulapp_s.lib ../../staticlib/components/xpconn ct.lib ../../staticlib/components/necko.lib ../../staticlib/components/uconv.li ../../staticlib/components/i18n.lib ../../staticlib/components/chardet.lib ../ ./staticlib/components/jar50.lib ../../staticlib/components/pref.lib ../../stat clib/components/caps.lib ../../staticlib/components/htmlpars.lib ../../staticli /components/imglib2.lib ../../staticlib/components/gklayout.lib ../../staticlib components/docshell.lib ../../staticlib/components/embedcomponents.lib ../../st ticlib/components/webbrwsr.lib ../../staticlib/components/nsappshell.lib ../../ taticlib/components/txmgr.lib ../../staticlib/components/chrome.lib ../../stati lib/components/commandlines.lib ../../staticlib/components/toolkitcomps.lib ../ ./staticlib/components/pipboot.lib ../../staticlib/components/pipnss.lib ../../ taticlib/components/gkplugin.lib ../../staticlib/components/mozfind.lib ../../s aticlib/components/appcomps.lib ../../staticlib/components/xpinstall.lib ../../ taticlib/components/jsd.lib ../../staticlib/components/autoconfig.lib ../../sta iclib/components/auth.lib ../../staticlib/components/cookie.lib ../../staticlib components/permissions.lib ../../staticlib/components/universalchardet.lib ../. /staticlib/components/composer.lib ../../staticlib/components/rdf.lib ../../sta iclib/components/windowds.lib ../../staticlib/components/intlapp.lib ../../stat clib/components/storagecomps.lib ../../staticlib/components/places.lib ../../st ticlib/components/tkautocomplete.lib ../../staticlib/components/satchel.lib ../ ./staticlib/components/pippki.lib ../../staticlib/components/ucvmath.lib ../../ taticlib/components/imgicon.lib ../../staticlib/components/gkgfxthebes.lib ../. /staticlib/components/gkwidget.lib ../../staticlib/components/spellchecker.lib ./../staticlib/components/zipwriter.lib ../../staticlib/xpcom_core.lib ../../st ticlib/ucvutil_s.lib ../../staticlib/gkgfx.lib ../../staticlib/gfxshared_s.lib ./../staticlib/mozreg_s.lib ../../staticlib/morkreader_s.lib ../../staticlib/th bes.lib ../../dist/lib/sqlite3.lib ../../jpeg/jpeg3250.lib ../../modules/l bimg/png/png.lib ../../gfx/qcms/mozqcms.lib c:/cygwin/home/user/hg/mozilla-cent al/objdir-winxp-dbg/xulrunner/dist/lib/js3250.lib c:/cygwin/home/user/hg/mozill -central/objdir-winxp-dbg/xulrunner/dist/lib/crmf.lib c:/cygwin/home/us r/hg/mozilla-central/objdir-winxp-dbg/xulrunner/dist/lib/smime3.lib c:/ ygwin/home/user/hg/mozilla-central/objdir-winxp-dbg/xulrunner/dist/lib/ssl3.lib c:/cygwin/home/user/hg/mozilla-central/objdir-winxp-dbg/xulrunner/dist/ ib/nss3.lib c:/cygwin/home/user/hg/mozilla-central/objdir-winxp-dbg/xul unner/dist/lib/nssutil3.lib c:/cygwin/home/user/hg/mozilla-central/objd r-winxp-dbg/xulrunner/dist/lib/softokn3.lib ../../gfx/cairo/cairo/src/mozcairo. ib ../../gfx/cairo/libpixman/src/mozlibpixman.lib ../../modules/zlib/src/mozz. ib c:/cygwin/home/user/hg/mozilla-central/objdir-winxp-dbg/xulrunner/dist/lib/n pr4.lib c:/cygwin/home/user/hg/mozilla-central/objdir-winxp-dbg/xulrunner/dist/ ib/plc4.lib c:/cygwin/home/user/hg/mozilla-central/objdir-winxp-dbg/xulrunner/d st/lib/plds4.lib shell32.lib ole32.lib uuid.lib version.lib winspool.lib comd g32.lib imm32.lib winmm.lib wsock32.lib msimg32.lib imagehlp.lib kernel32.lib u er32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib usp10.lib oleaut32.lib LIBCMTD.lib(sprintf.obj) : error LNK2005: _sprintf already defined in MSVCRTD.l b(MSVCR90D.dll) LIBCMTD.lib(dbgheap.obj) : error LNK2005: __malloc_dbg already defined in MSVCR D.lib(MSVCR90D.dll) LIBCMTD.lib(dbgheap.obj) : error LNK2005: __free_dbg already defined in MSVCRTD lib(MSVCR90D.dll) LIBCMTD.lib(dbgheap.obj) : error LNK2005: __CrtSetCheckCount already defined in MSVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(invarg.obj) : error LNK2005: __invalid_parameter already defined in MSVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(invarg.obj) : error LNK2005: __set_invalid_parameter_handler alread defined in MSVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(dbghook.obj) : error LNK2005: __crt_debugger_hook already defined i MSVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(sbheap.obj) : error LNK2005: __set_sbh_threshold already defined in MSVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(setlocal.obj) : error LNK2005: _setlocale already defined in MSVCRT .lib(MSVCR90D.dll) LIBCMTD.lib(tidtable.obj) : error LNK2005: __encode_pointer already defined in SVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(tidtable.obj) : error LNK2005: __encoded_null already defined in MS CRTD.lib(MSVCR90D.dll) LIBCMTD.lib(tidtable.obj) : error LNK2005: __decode_pointer already defined in SVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(printf.obj) : error LNK2005: _printf already defined in MSVCRTD.lib MSVCR90D.dll) LIBCMTD.lib(dbgrptw.obj) : error LNK2005: __CrtDbgReportW already defined in MS CRTD.lib(MSVCR90D.dll) LIBCMTD.lib(crt0dat.obj) : error LNK2005: _exit already defined in MSVCRTD.lib( SVCR90D.dll) LIBCMTD.lib(crt0dat.obj) : error LNK2005: __exit already defined in MSVCRTD.lib MSVCR90D.dll) LIBCMTD.lib(crt0dat.obj) : error LNK2005: __amsg_exit already defined in MSVCRT .lib(MSVCR90D.dll) LIBCMTD.lib(crt0dat.obj) : error LNK2005: __initterm_e already defined in MSVCR D.lib(MSVCR90D.dll) LIBCMTD.lib(dosmap.obj) : error LNK2005: __errno already defined in MSVCRTD.lib MSVCR90D.dll) LIBCMTD.lib(lconv.obj) : error LNK2005: _localeconv already defined in MSVCRTD. ib(MSVCR90D.dll) LIBCMTD.lib(mlock.obj) : error LNK2005: __lock already defined in MSVCRTD.lib(M VCR90D.dll) LIBCMTD.lib(mlock.obj) : error LNK2005: __unlock already defined in MSVCRTD.lib MSVCR90D.dll) LIBCMTD.lib(winxfltr.obj) : error LNK2005: ___CppXcptFilter already defined in SVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(osfinfo.obj) : error LNK2005: __open_osfhandle already defined in M VCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(_file.obj) : error LNK2005: ___iob_func already defined in MSVCRTD. ib(MSVCR90D.dll) LIBCMTD.lib(crt0init.obj) : error LNK2005: ___xi_a already defined in MSVCRTD.l b(cinitexe.obj) LIBCMTD.lib(crt0init.obj) : error LNK2005: ___xi_z already defined in MSVCRTD.l b(cinitexe.obj) LIBCMTD.lib(crt0init.obj) : error LNK2005: ___xc_a already defined in MSVCRTD.l b(cinitexe.obj) LIBCMTD.lib(crt0init.obj) : error LNK2005: ___xc_z already defined in MSVCRTD.l b(cinitexe.obj) LIBCMTD.lib(hooks.obj) : error LNK2005: "void __cdecl terminate(void)" (?termin te@@YAXXZ) already defined in MSVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(winsig.obj) : error LNK2005: _raise already defined in MSVCRTD.lib( SVCR90D.dll) LIBCMTD.lib(fflush.obj) : error LNK2005: _fflush already defined in MSVCRTD.lib MSVCR90D.dll) LIBCMTD.lib(getenv.obj) : error LNK2005: _getenv already defined in MSVCRTD.lib MSVCR90D.dll) LIBCMTD.lib(tolower.obj) : error LNK2005: _tolower already defined in MSVCRTD.l b(MSVCR90D.dll) MSVCRTD.lib(MSVCR90D.dll) : error LNK2005: __fileno already defined in LIBCMTD. ib(fileno.obj) Creating library xul.lib and object xul.exp LINK : warning LNK4098: defaultlib 'MSVCRTD' conflicts with use of other libs; se /NODEFAULTLIB:library LINK : warning LNK4098: defaultlib 'LIBCMTD' conflicts with use of other libs; se /NODEFAULTLIB:library LIBCMTD.lib(crt0.obj) : error LNK2019: unresolved external symbol _main referen ed in function ___tmainCRTStartup xul.dll : fatal error LNK1120: 1 unresolved externals make[1]: *** [xul.dll] Error 96 make[1]: Leaving directory `/c/cygwin/home/user/hg/mozilla-central/objdir-winxp dbg/xulrunner/toolkit/library' make: *** [all] Error 2 make: Leaving directory `/c/cygwin/home/user/hg/mozilla-central/objdir-winxp-db /xulrunner/toolkit/library'
.mozconfig mk_add_options MOZ_BUILD_PROJECTS="xulrunner mobile" ac_add_options --enable-debug ac_add_options --disable-optimize ac_add_options --disable-timeline ac_add_options --enable-plugins ac_add_options --enable-xpinstall mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/objdir-winxp-dbg # mobile options ac_add_app_options mobile --enable-application=mobile ac_add_app_options mobile --with-libxul-sdk=../xulrunner/dist ac_add_options --disable-tests ac_add_options --disable-javaxpcom ac_add_options --disable-accessibility ac_add_options --disable-printing ac_add_options --disable-oji ac_add_options --disable-vista-sdk-requirements ac_add_options --disable-updater ac_add_options --disable-installer ac_add_options --enable-image-decoders="png gif jpeg bmp icon" ac_add_options --disable-dbm ac_add_options --disable-jemalloc ac_add_options --disable-ogg ac_add_options --enable-default-toolkit=cairo-windows
I also am seeing this bug trying to build fennec for Win32.
Ok, so this is a debug xulrunner build? We probably didn't hit this on Firefox because configure disables libxul for debug builds there. I'll see what I can do.
Assignee: nobody → ted.mielczarek
Blocks: 487396
Ok, I can reproduce.
Summary: build error in toolkit/library → debug libxul build broken
This is from the change in xpcom/typelib/xpt/Makefile.in. It added "USE_STATIC_LIBS = 1", but that static lib gets linked into libxul and causes this bustage.
Attached patch bustage fix (obsolete) — — Splinter Review
This WFM here on a debug xulrunner build, I'm going to run it by the try server to make sure it doesn't break the normal config.
Comment on attachment 374507 [details] [diff] [review] bustage fix Oops, forgot about this patch.
Attachment #374507 - Flags: review?(benjamin)
Attachment #374507 - Flags: review?(benjamin) → review+
Comment on attachment 374507 [details] [diff] [review] bustage fix Actually, no. I think you want to replicate this block http://mxr.mozilla.org/mozilla-central/source/xpcom/typelib/xpidl/Makefile.in#147 so that library can be linked into static or nonstatic situations.
Attachment #374507 - Flags: review+ → review-
Assignee: ted.mielczarek → benjamin
Attachment #374507 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #377203 - Flags: review?(ted.mielczarek)
Comment on attachment 377203 [details] [diff] [review] Sprinkle -NODEFAULTLIB around xpt-land, rev. 1 WFM, thanks for patching this.
Attachment #377203 - Flags: review?(ted.mielczarek) → review+
Still errors in toolkit/library. LIBCMTD.lib(sprintf.obj) : error LNK2005: _sprintf already defined in MSVCRTD.li b(MSVCR90D.dll) LIBCMTD.lib(dbgheap.obj) : error LNK2005: __malloc_dbg already defined in MSVCRT D.lib(MSVCR90D.dll) LIBCMTD.lib(dbgheap.obj) : error LNK2005: __free_dbg already defined in MSVCRTD. lib(MSVCR90D.dll) LIBCMTD.lib(dbgheap.obj) : error LNK2005: __CrtSetCheckCount already defined in MSVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(invarg.obj) : error LNK2005: __invalid_parameter already defined in MSVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(invarg.obj) : error LNK2005: __set_invalid_parameter_handler already defined in MSVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(dbghook.obj) : error LNK2005: __crt_debugger_hook already defined in MSVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(sbheap.obj) : error LNK2005: __set_sbh_threshold already defined in MSVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(setlocal.obj) : error LNK2005: _setlocale already defined in MSVCRTD .lib(MSVCR90D.dll) LIBCMTD.lib(tidtable.obj) : error LNK2005: __encode_pointer already defined in M SVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(tidtable.obj) : error LNK2005: __encoded_null already defined in MSV CRTD.lib(MSVCR90D.dll) LIBCMTD.lib(tidtable.obj) : error LNK2005: __decode_pointer already defined in M SVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(printf.obj) : error LNK2005: _printf already defined in MSVCRTD.lib( MSVCR90D.dll) LIBCMTD.lib(dbgrptw.obj) : error LNK2005: __CrtDbgReportW already defined in MSV CRTD.lib(MSVCR90D.dll) LIBCMTD.lib(crt0dat.obj) : error LNK2005: _exit already defined in MSVCRTD.lib(M SVCR90D.dll) LIBCMTD.lib(crt0dat.obj) : error LNK2005: __exit already defined in MSVCRTD.lib( MSVCR90D.dll) LIBCMTD.lib(crt0dat.obj) : error LNK2005: __amsg_exit already defined in MSVCRTD .lib(MSVCR90D.dll) LIBCMTD.lib(crt0dat.obj) : error LNK2005: __initterm_e already defined in MSVCRT D.lib(MSVCR90D.dll) LIBCMTD.lib(dosmap.obj) : error LNK2005: __errno already defined in MSVCRTD.lib( MSVCR90D.dll) LIBCMTD.lib(lconv.obj) : error LNK2005: _localeconv already defined in MSVCRTD.l ib(MSVCR90D.dll) LIBCMTD.lib(mlock.obj) : error LNK2005: __lock already defined in MSVCRTD.lib(MS VCR90D.dll) LIBCMTD.lib(mlock.obj) : error LNK2005: __unlock already defined in MSVCRTD.lib( MSVCR90D.dll) LIBCMTD.lib(winxfltr.obj) : error LNK2005: ___CppXcptFilter already defined in M SVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(osfinfo.obj) : error LNK2005: __open_osfhandle already defined in MS VCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(_file.obj) : error LNK2005: ___iob_func already defined in MSVCRTD.l ib(MSVCR90D.dll) LIBCMTD.lib(crt0init.obj) : error LNK2005: ___xi_a already defined in MSVCRTD.li b(cinitexe.obj) LIBCMTD.lib(crt0init.obj) : error LNK2005: ___xi_z already defined in MSVCRTD.li b(cinitexe.obj) LIBCMTD.lib(crt0init.obj) : error LNK2005: ___xc_a already defined in MSVCRTD.li b(cinitexe.obj) LIBCMTD.lib(crt0init.obj) : error LNK2005: ___xc_z already defined in MSVCRTD.li b(cinitexe.obj) LIBCMTD.lib(hooks.obj) : error LNK2005: "void __cdecl terminate(void)" (?termina te@@YAXXZ) already defined in MSVCRTD.lib(MSVCR90D.dll) LIBCMTD.lib(winsig.obj) : error LNK2005: _raise already defined in MSVCRTD.lib(M SVCR90D.dll) LIBCMTD.lib(fflush.obj) : error LNK2005: _fflush already defined in MSVCRTD.lib( MSVCR90D.dll) LIBCMTD.lib(getenv.obj) : error LNK2005: _getenv already defined in MSVCRTD.lib( MSVCR90D.dll) LIBCMTD.lib(tolower.obj) : error LNK2005: _tolower already defined in MSVCRTD.li b(MSVCR90D.dll) MSVCRTD.lib(MSVCR90D.dll) : error LNK2005: __fileno already defined in LIBCMTD.l ib(fileno.obj) Creating library xul.lib and object xul.exp LINK : warning LNK4098: defaultlib 'MSVCRTD' conflicts with use of other libs; u se /NODEFAULTLIB:library LINK : warning LNK4098: defaultlib 'LIBCMTD' conflicts with use of other libs; u se /NODEFAULTLIB:library LIBCMTD.lib(crt0.obj) : error LNK2019: unresolved external symbol _main referenc ed in function ___tmainCRTStartup xul.dll : fatal error LNK1120: 1 unresolved externals make[1]: *** [xul.dll] Error 96 make[1]: Leaving directory `/c/cygwin/home/user/hg/mozilla-central/objdir-winxp- dbg/xulrunner/toolkit/library' make: *** [all] Error 2
Attached patch A patch — — Splinter Review
adding -NODEFAULTLIB:LIBCMTD solves the errors.
Attachment #377323 - Flags: review?(ted.mielczarek)
Comment on attachment 377323 [details] [diff] [review] A patch I defer to bsmedberg.
Attachment #377323 - Flags: review?(ted.mielczarek) → review?(benjamin)
This is blocking being able to run unittests on debug builds on windows, since we need to compile with --enable-libxul.
Comment on attachment 377323 [details] [diff] [review] A patch This is not the right place for this... you probably just need to add libcmtd to xpcom/typelib/xpt/src/Makefile.in as in my patch.
Attachment #377323 - Flags: review?(benjamin) → review-
(In reply to comment #15) > (From update of attachment 377323 [details] [diff] [review]) > This is not the right place for this... you probably just need to add libcmtd > to xpcom/typelib/xpt/src/Makefile.in > as in my patch. Hmm, I got the same errors in comment #11 after adding -NODEFAULTLIB:LIBCMTD to LDFLAGS in xpcom/typelib/xpt/src/Makefile.in. Am I missing something?
FWIW, I ran into exactly these kind of errors while trying to get debug XRs going for Songbird; I also spent a fair amount of time trying to work around it by sprinkling flags in various Makefiles. In the end, I just bit the bullet and implemented a jemalloc-enabled debug mozcrt. A working implementation (based off the 1.9.0-branch) is sitting in bug 429745. It's a relatively large patch, but there are techniques to reduce the risk (e.g. some diffing if you have the CRT source) to show that it's not as risky as the posted patch would imply). I didn't bother doing any of that because I didn't really have time to work on it anymore and it wasn't going to meet the Firefox 3.0 schedule anyway. Songbird has had working debug XRs for about ten months now, and they _seem_ to work beautifully.
I am sorry, there is no errors from clean build after adding -NODEFAULTLIB:LIBCMTD to LDFLAGS in xpcom/typelib/xpt/src/Makefile.in.
I confirmed attachment 377323 [details] [diff] [review] without -NODEFAULTLIB:LIBCMTD does not cause any errors from clean build. Though the following warning is still here, anyway it can be built. LINK : warning LNK4098: defaultlib 'LIBCMTD' conflicts with use of other libs;
Some library has LIBCMTD in its default libs. Whatever library that is, we need to find and fix it.
You can use: dumpbin -directives /path/to/whatever.lib | grep -i libcmtd to check.
or dumpbin -dependents ...
Blocks: 372581
I face the linker errors in comment #11 now. I am confused. Anyway, the results of dumpbin.exe are: $ dumpbin.exe -dependents xpt.lib Microsoft (R) COFF/PE Dumper Version 9.00.30729.01 Copyright (C) Microsoft Corporation. All rights reserved. Dump of file xpt.lib File Type: LIBRARY Summary F71 .data B8E0 .debug$S 18C .debug$T 90 .drectve 37F6 .text $ dumpbin.exe -directives xpt.lib Microsoft (R) COFF/PE Dumper Version 9.00.30729.01 Copyright (C) Microsoft Corporation. All rights reserved. Dump of file xpt.lib File Type: LIBRARY Linker Directives ----------------- /DEFAULTLIB:"LIBCMTD" /DEFAULTLIB:"OLDNAMES" Linker Directives ----------------- /DEFAULTLIB:"LIBCMTD" /DEFAULTLIB:"OLDNAMES" Linker Directives ----------------- /DEFAULTLIB:"LIBCMTD" /DEFAULTLIB:"OLDNAMES" Summary F71 .data B8E0 .debug$S 18C .debug$T 90 .drectve 37F6 .text These results also confuses me. xpt.lib has LIBCMTD?
I found others which has LIBCMTD. These are modules/libreg/standalone/mozregsa_s.lib and build/xpcom/xpcom_core.lib.
(In reply to comment #24) > I found others which has LIBCMTD. These are > modules/libreg/standalone/mozregsa_s.lib and build/xpcom/xpcom_core.lib. Oops! I am sorry. These have LIBCMT not LIBCMTD.
dumpbin -dependents is used on the dll, not on the lib. Sorry.
I noticed xpt.lib is created by lib.exe not link.exe, so LDFLAGS is not useless here. So I added AR_FLAGS with -NODEFAULTLIB:LIBCMTD, but nevertheless xpt.lib still has LIBCMTD. I found that removal -MTd option solves this issue. Can't we remove this option? If we remove the option, we can not debug any more? http://mxr.mozilla.org/mozilla-central/source/config/config.mk#575
(In reply to comment #27) > I noticed xpt.lib is created by lib.exe not link.exe, so LDFLAGS is not useless LDFLAGS *is* useless.
-NODEFAULTLIB applies when link is linking, it will override directives from static libraries.
This got r=ted on IRC. It's copied directly from xpcom/glue/Makefile.in
Attachment #379152 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/7bbdbdfda2b4
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: