Closed Bug 489278 Opened 11 years ago Closed 10 years ago

please QA the Geolocation landing page (for 3.5 b4)

Categories

(www.mozilla.org :: General, defect, major)

defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jslater, Assigned: stephend)

References

()

Details

Apologies for the late-breaking request, but this Geolocation page was a late add for 3.5 b4...it needs to be ready before the beta release goes out, as it's going to be linked to from within the product.

A known issue is that the Google privacy policy link doesn't work right now...that's being addressed.

Thanks!
Blocks: 488497
I don't see a spec for this, so trusting that the content is OK with the mobile team (dougt will know more):

[1] Site doesn't validate (4 errors, last I checked)
[2] https://www-trunk.stage.mozilla.com/en-US/firefox/geolocation/TODO is a 404

More later (Krupa might have something to add too).
(In reply to comment #1)
> [1] Site doesn't validate (4 errors, last I checked)

Oh, sorry, I forgot to validate it myself :( Fixed in r24616: It now validates. It was a half-open <p> tag which caused three more parsing errors...
Thanks, page now validates!
This is probably a known issue,but I'll go ahead and mention it anyways-

Along with the Google privacy policy,the link "Google Location Services" which links to https://www-trunk.stage.mozilla.com/en-US/firefox/geolocation/TODO is also a 404.
(In reply to comment #4)
> This is probably a known issue,but I'll go ahead and mention it anyways-
> 
> Along with the Google privacy policy,the link "Google Location Services" which
> links to https://www-trunk.stage.mozilla.com/en-US/firefox/geolocation/TODO is
> also a 404.

Yes, mentioned in comment 1 :-)
I have many objections to this text, see my comment in bug 488497 comment #19.
Thanks guys, this is live now.

Re: comment 6, Mike Beltzner asked you to please file a followup bug if you would like to suggest improvements.
Assignee: nobody → stephen.donner
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
(In reply to comment #7)
> Thanks guys, this is live now.

http://www.mozilla.com/en-US/firefox/geolocation/ is a 404; am I missing something?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to comment #8)
> (In reply to comment #7)
> > Thanks guys, this is live now.
> 
> http://www.mozilla.com/en-US/firefox/geolocation/ is a 404; am I missing
> something?

Oh, sorry, that's bug 488497, which Beltzner is still working on; apparently my tea wasn't strong enough this AM.
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Reopening.

1/ <div class="expander expander-odd" id="whatisphishing">
the whatisphishing id should be removed

2/"If you say don’t consent, Firefox will not do anything."
Seems unclear to me, I would say "If you say that you do not consent, Firefox will not do anything."

3/ "our third party service" I am not sure but maybe third party should be hyphenated as third-party since it is an adjective

4/ 
    * your computer’s IP address,
    * information about the nearby wireless access points, and
    * a random client identifier, which is assigned by Google, that expires every 2 weeks.

Shouldn't the 'and' word be in the last list item? Like:
    * and a random client identifier, which is assigned by Google, that expires every 2 weeks.

5/ "For a complete list of description on information..."
That phrase seems unclear to me, should "description" be in plural form if it is a list ?

6/"For a complete list of description on information collected and used by Firefox, please see the Location-Aware Feature Privacy Policy."

That links to the Firefox privacy policy which I believe is the right document, the Location-Aware Feature Privacy Policy is the document the user is currently looking at


7/ References to menu items should be marked as <em> so as to make them stand out, currently the only diferenciator is the capital letter in English but not all languages use capital letters

8/ code: like for other in-product pages, the $extra-headers part and non-localizable variables should be in a common include shared by all locales for future maintenance (as we did for firstrun and whatsnew last week)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pascal's edits from comment #10 look good to me (except for #6...more on that below). Fred, can you make these tweaks so his team can begin localizing?

(In reply to comment #10)
> 5/ "For a complete list of description on information..."
> That phrase seems unclear to me, should "description" be in plural form if it
> is a list ?
Let's change that to read "For a complete description of..."

> 6/"For a complete list of description on information collected and used by
> Firefox, please see the Location-Aware Feature Privacy Policy."
> That links to the Firefox privacy policy which I believe is the right document,
> the Location-Aware Feature Privacy Policy is the document the user is currently
> looking at
Pascal, can you clarify this one before we make changes?
>Pascal, can you clarify this one before we make changes?

The link goes to the General Firefox privacy policy, the sentence should be:

"For a complete list of description on information collected and used by Firefox, please see the Firefox Privacy Policy"
(In reply to comment #11)
> Fred, can you make these tweaks so his team can begin localizing?

Sure.
points 1--3, done.

4: no. AFAIK it's customary to have the "and" at the end of the second to last bullet point.

5--7: done.

8: Pascal, I can't seem to find an example of a page that has different includes than the ones we are using here. Can you point me to the right spot?
Status: REOPENED → NEW
These first fixes are in r25238.
>: Pascal, I can't seem to find an example of a page that has different
includes than the ones we are using here. Can you point me to the right spot?

Here is one, we do that now for in-product pages for which we will create a version per locale.
http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/en-US/firefox/3.5/firstrun/index.html?revision=25180&view=markup
Done: r25242.
Status: NEW → RESOLVED
Closed: 11 years ago10 years ago
Resolution: --- → FIXED
Hey guys. Sorry to reopen this, but we need to add one more question & answer to the FAQ. Once that change has been made let me know which file(s) to push and I'll handle that.

Here's the content...thanks!


How do I turn off Location-Aware Browsing permanently?

Location-Aware Browsing is always opt-in in Firefox 3.5. No location information is ever sent without your permission. If you wish to disable the feature completely, please follow this set of steps:
* In the URL bar, type about:config
* Right-click (or control-click in Mac OS X) anywhere in the Preference Names area and select "New", then "Boolean"
* At the prompt to enter the preference name, type "geo.enabled" and click "OK"
* At the next prompt, select "false" and click "OK"
* Location-Aware Browsing is now disabled
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
r25244. I'll push this into the prod queue for you to publish shortly, will comment here again then.
John: The files in question are now in kubla's production queue, all tagges "geo-info". Please push them live, unless further changes are necessary.
(In reply to comment #20)
> John: The files in question are now in kubla's production queue, all tagges
> "geo-info". Please push them live, unless further changes are necessary.
Frédéric, thanks for taking care of this so quickly. You rock!

I just pushed the files live through Kubla, but had a couple of connection errors along the way. I *think* they all made it through, but could I get a QA double-check on that?

Pascal, once we get confirmation that the changes went live this one should be all set for l10n.
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
"Preference Names" should not be plural; the rest of it looks OK, but I'm not vetting content.
Hey Fred: Can you make one more edit, please? 

Please change the text under the question: "How accurate are the locations?"

New text: 

Accuracy varies greatly from location to location.  In some places, our service providers may be able to provide a location to within a few meters.  However, in other areas it might be much more than that.  All locations returned by our service providers are estimates only and we do not guarantee the accuracy of the locations provided.  Please do not use this information for emergencies. Always use common sense.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Fred, please make Stephen's comment #22 while you're at it...thanks!!
Fred, please make Stephen's comment #22 while you're at it...thanks!! Sorry about all the last minute changes on this one.
I made both of these changes in r25257. The geolocation/index.html file is in the prod queue in kubla, please push it live.
(In reply to comment #26)
> I made both of these changes in r25257. The geolocation/index.html file is in
> the prod queue in kubla, please push it live.
Thanks Fred!! I just pushed the file and am resolving as fixed.

Note to all: Pascal needs to submit this page to l10n by EOD today, after which point we really shouldn't change the text again. So, consider this your final final call to make any edits (note: no more edits unless they're *really* necessary!).
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
we added geo.enabled as a default pref.  so the answer to the question "How do I turn off Location-Aware Browsing permanently?" should read:

1) In the URL bar, type about:config
2) Type "geo.enabled"
3) Double click on the "geo.enabled" preference
4) Location-Aware Browsing is now disabled

sorry, but this is a better user experience, for sure.
Also, we changed the way that you can undo the "Remember this decision" checkbox. It should now read:

----

If you’ve given Firefox permission always give your your location to a site and later change your mind, you can easily revoke that permission. Here’s how:

    * Go to the Tools menu, then select Page Info
    * Select the Permissions tab
    * Change the setting for Share Location

----
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Hm, perhaps actually:

----

If you’ve given Firefox permission always give your your location to a site and
later change your mind, you can easily revoke that permission. Here’s how:

    * Navigate to the site to which you've given permission
    * Go to the Tools menu, then select Page Info
    * Select the Permissions tab
    * Change the setting for Share Location

----
typo in #30. corrected below ( s/given Firefox permission always give your your/given Firefox permission to always give your/ ):

If you've given Firefox permission to always give your location to a site and
later change your mind, you can easily revoke that permission. Here's how:

    * Navigate to the site to which you've given permission
    * Go to the Tools menu, then select Page Info
    * Select the Permissions tab
    * Change the setting for Share Location

Fred: changes to take are #28 and this one.
r25354. It hasn't shown up on kubla yet for some reason, though.
I pushed it to the kubla prod queue, please push it live.
(In reply to comment #33)
> I pushed it to the kubla prod queue, please push it live.
Pushed! (thanks Fred)

Not marking this one as resolved yet b/c I'm hearing that we want to add a small demo to this page, so we might as well get that figured out first. Also, this won't require any text changes, but we should have a new geolocation illustration for this page in the next 24 hours or so that will need to be added as well.

Getting closer, though...
Are there any other changes you guys can think of?  Would like to batch these changes so Fred doesn't have to keep context switching.  <3
Quick update on this:
I sent Fred the illustration earlier today, so the main thing left at this point (I think) is the demo that Doug is working on. Not too much longer now...
how is this for an example:

http://people.mozilla.org/~dougt/geo_example/

(if you move it off of p.m.o, you are going to have to request a new api key from google.com)
mike, you want to do something more sexy, yelp has a geo api, and so does flickr (http://people.mozilla.org/~dougt/flickr.html).
What is the status here? I need to go forward with the localization of this document as this is a Firefox 3.5 release blocker for our 70 locales.
(In reply to comment #40)
> What is the status here? I need to go forward with the localization of this
> document as this is a Firefox 3.5 release blocker for our 70 locales.
Yep, you're totally right that this needs to get wrapped up ASAP.

Pascal, is it an option to go ahead and add a "Try the demo" link to this page even if the demo isn't actually working yet? If so, we could finalize the text and then update the link to point to the correct demo when it's ready.

If that's not feasible, I recommend that we go ahead and release this page for l10n as is and just have the demo be for en-US. That's not ideal, but there's a lot of text here that needs to be localized and it's time to get started on that.
I updated the illustrations in r25574.
(In reply to comment #42)
> I updated the illustrations in r25574.
Thanks Fred...which file(s) should I push for that?

As for the demo, my vote is for the one in #37 (seems to be basically the same as #38, right?). Mike, could you guys polish that up a bit for final release? I think that would basically include adding a "Try the demo" link under the subhead that would generate a lightbox that shows the user's location (and of course would ask for their permission just like geolocation normally does). I'm happy to discuss further and am open to any other ideas you guys have too, of course.
(In reply to comment #43)
> (In reply to comment #42)
> > I updated the illustrations in r25574.
> Thanks Fred...which file(s) should I push for that?

I just pushed three files to the prod queue, all tagged "geo-info".
New illustration is live - thanks Fred!

Pascal - let us know about my comment #41.
Mike - ditto for comment #43
(In reply to comment #45)
> Mike - ditto for comment #43

Mike's on the road today, but he'll probably get back to us tomorrow. I can stuff dougt's demo into a lightbox, and link to it from the "give it a try!" text. That text (and the lightbox of course) would not show up at all for non-JS users, by the way.

I can work on it tomorrow. Please look at the example from comment 37 again and suggest any (text / layout) changes you may require from what Doug put into the example. In particular, "then shares your location with Google" may be misleading, as the location is determined by Google in the first place, then sent back to Google (Maps) to show it graphically.
Status: REOPENED → NEW
very cool!

non-js users should probably get a warning that this demo and geolocation in general requires javascript to be enabled.
(In reply to comment #46)
> I can work on it tomorrow. Please look at the example from comment 37 again and
> suggest any (text / layout) changes you may require from what Doug put into the
> example. In particular, "then shares your location with Google" may be
> misleading, as the location is determined by Google in the first place, then
> sent back to Google (Maps) to show it graphically.

I'd suggest making this as simple as possible - because it would make l10n easier and because the current text probably confuses things more than it helps. 

The text on the page itself covers what geolocation is and how it works pretty clearly, so I don't think we need to explain it again in the lightbox. So, how about this:
- pretty lightbox as described in comment #46
- button that reads "Where am I?"
- map just like in the current demo

I think that alone would be a pretty powerful example of how this works.

Also, Pascal, Fred makes a good point in comment #46...we don't actually need a "Try the demo" link like I was suggesting in comment #41, because we already have the "Give it a try!" text built in. So, if you want to localize this page the only extra thing would be the "Where am I?" text on the button (assuming everyone is cool with this plan).
Sounds good to me. Simple and straightforward.
Where would the "where am I" button would be located in the html ?
(In reply to comment #50)
> Where would the "where am I" button would be located in the html ?
It'd be in the lightbox along with the map...Fred can give you more details about the code itself, of course, if that's what you're looking for.
(In reply to comment #51)
> (In reply to comment #50)
> > Where would the "where am I" button would be located in the html ?
> It'd be in the lightbox along with the map...Fred can give you more details
> about the code itself, of course, if that's what you're looking for.

Yes, that's what I am looking for, to put a marker there.
Once the code exists, I can point it out.
I made a demo in r25681. Please take a look at https://www-trunk.stage.mozilla.com/en-US/firefox/geolocation/ and tell me what you think. Also note the error text that's shown when you deny the geolocation request or when any other error occurs.
ok, so that's 4 more strings:

Give it a try!
Where am I?
busy
Oops! An error occurred while trying to determine your position.

Is the html demo code final or is that just a draft? If it is not final, maybe we can put it in an include and use variables like that:

<?php
$geostr1="Where am I?";
$geostr2="busy";
$geostr3="Oops! An error occurred while trying to determine your position.";
include '/path/to/geolocation.map.inc.php';
?>

If it is final html for the map, then I will launch localization today.
If jslater approves, it is final.
Doesn't look like comment 47 was addressed (at least, not by my testing); should it be?
(In reply to comment #57)
> Doesn't look like comment 47 was addressed (at least, not by my testing);
> should it be?
Agreed. Fred, can you make that quick fix? Then we'll be good to go.
Sure, but where? The "try it out" link does not even show up for non-JS at the moment. Do you want a sentence right before the frequently asked questions?
(In reply to comment #59)
> Sure, but where? The "try it out" link does not even show up for non-JS at the
> moment. Do you want a sentence right before the frequently asked questions?
Oh, I didn't realize that...sorry. In that case, I think we're fine as is...I don't see any big need to add an explanation/warning for something that people wouldn't be seeing anyway.

One question before we officially wrap this up: is the demo working for everybody else? I'm running 3.5b4, but I've gotten the "Oops! An error occurred while trying to determine your position." message 9 out of 10 times.
(In reply to comment #60)
> (In reply to comment #59)
> > Sure, but where? The "try it out" link does not even show up for non-JS at the
> > moment. Do you want a sentence right before the frequently asked questions?
> Oh, I didn't realize that...sorry. In that case, I think we're fine as is...I
> don't see any big need to add an explanation/warning for something that people
> wouldn't be seeing anyway.

Yeah, I was thinking the same thing.

> One question before we officially wrap this up: is the demo working for
> everybody else? I'm running 3.5b4, but I've gotten the "Oops! An error occurred
> while trying to determine your position." message 9 out of 10 times.

Could that be bug 490740? It seems to work pretty consistently (with varying degrees of accuracy) for me on a nightly version of Firefox. On 3.5b4, I do get the error you are describing more often than not.
Another question, sorry. When you look at the page in any uncompatible browser (that includes MSIE, Safari, and older Firefoxes), you'll see the lightbox, and clicking on the button will just not do anything. Is that okay, or do we need to sniff Gecko versions?
It is an in-product pages, it is considered as part of the software we ship and is not meant to be promoted or linked from other places, so I would say that this is not a problem if it doesn't work in older browser, just like we know that <video> on firstrun/whatsnew does not work in old browsers.
john, can you try in a nightly ?
Re: comments #62 & 63. Pascal is right that this is primarily an in-product page and the vast majority of traffic will come from 3.5 users, but I'd also like to be able to link to it from places like our Firefox Features and Under the Hood pages, which would mean some traffic from other browsers.

How hard is it to sniff the browser version and then just not show the demo link for non-3.5 users? If it's at all difficult then I'll just drop my plan of linking to it from Features & Under the Hood...not a huge deal.
(In reply to comment #65)
> How hard is it to sniff the browser version and then just not show the demo
> link for non-3.5 users?

It's actually trivial. I was just a little slow earlier, sorry. The link will only be shown to browsers that have the geolocation feature (i.e., also on Fx3+Geode, for example). r25746.

This is done on my end, now. I'll push it to the prod queue, unless there's anything else we need.
(In reply to comment #66)
> This is done on my end, now. I'll push it to the prod queue, unless there's
> anything else we need.

Please do! This page is approved on my end - let me know what files you need me to push when they're ready.
Done: They are all tagged geo-info again.
Published...thanks Fred!!
Status: NEW → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
localization started, I have added the class="external" to the google links, I think it should be done for en-US as well.
I added these too: r25780. John, if you want to push it live, it's the geolocation/index.html file. (This is blocked on bug 493207, though).
does anyone feel that the "Where am I?" button doesn't really stand out?  I clicked on "Give it a try" then waited a bit after the map loaded wondering what I was to do next.
I agree. It does not stand out enough in IMO.

(In reply to comment #72)
> does anyone feel that the "Where am I?" button doesn't really stand out?  I
> clicked on "Give it a try" then waited a bit after the map loaded wondering
> what I was to do next.
For 3.5b4, the Share Location setting on the Page Info window is not yet available. Could you add a note at least for a while?
... and one more note: "This feature doesn't work when your computer's wireless LAN connection (AirPort on Mac OS X) is disabled."
Kohei, the feature will fallback to IP Geo if your WiFi is off and you are wired.
At this office, I cannot actually use the feature when AirPort is disabled. IP Geo doesn't always work, right? So I mean, "When your computer's WiFi (AirPort on Mac) is disabled, this feature may not work or the accuracy of the locations will be reduced."
kohei, i think this is covered in "how accurate are the locations" section.  do you agree?
I see. I'll add such a note to our Japanese translation. (In Japan, most mobile phones have a GPS location service, so people will expect a high degree of accuracy.)

My comment 74 and 76 are not specific to 3.5b4. Sorry for bugspam.

I found one more thing on 3.5b4: the geo.enabled preference could not be found on about:config. This should be noted along with an issue in my comment 74.
(In reply to comment #79)
> I found one more thing on 3.5b4: the geo.enabled preference could not be found
> on about:config. This should be noted along with an issue in my comment 74.

We used to have that, and changed it due to it being a default pref now (cf. comment 28).

PS: Please open new bugs when issues occur, this one is getting quite long already and is -- quite honestly -- inappropriately named, too.
(In reply to comment #79)
> (...)
> I found one more thing on 3.5b4: the geo.enabled preference could not be found
> on about:config. (...)

This is bug 491653 (fixed in 3.5b5, according to this bug).
I really think this part should be rewritten:

<li>In the URL bar, type <code>about:config</code></li>
<li>Type <code>geo.enabled</code></li>
<li>Double click on the <em>geo.enabled</em> preference</li>
<li>Location-Aware Browsing is now disabled</li>

We shouldn't direct average user to the about:config page as this page is dangerous.

Plus, the description is not correct as we got a warning before entering.

The more user-friendly way I see, would be to indicate:
Tools > Page info > Permissions. Uncheck the "Share location" checkbox then select the radio button "Block".

Sorry to jump in so late, but I saw this when localizing this page.
(In reply to comment #82)
> I really think this part should be rewritten:
> 
> <li>In the URL bar, type <code>about:config</code></li>
> <li>Type <code>geo.enabled</code></li>
> <li>Double click on the <em>geo.enabled</em> preference</li>
> <li>Location-Aware Browsing is now disabled</li>
> 
> We shouldn't direct average user to the about:config page as this page is
> dangerous.
> 
> Plus, the description is not correct as we got a warning before entering.
> 
> The more user-friendly way I see, would be to indicate:
> Tools > Page info > Permissions. Uncheck the "Share location" checkbox then
> select the radio button "Block".
> 
> Sorry to jump in so late, but I saw this when localizing this page.

That's not a problem if you jump in late, bugs are there to be filed -- just make a new bug for a new issue like this though, please. Thanks!
Reopening for issues on *3.5b4* (this bug says so.)

From my comment 74 and 79:

* the Share Location setting on the Page Info window is not yet available
* the geo.enabled preference could not be found on about:config

Please add notes at least until rc1 is available.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
No one dealt with the issues above and phase b4 ended today.

Marking RESOLVED again.
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Component: www.mozilla.org/firefox → www.mozilla.org
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.