489512 - Explore hooking the rest of strings in about:crashes to Cocoa l10n

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Since we actually have a forked copy of crashes.xhtml, we can modify the file if we want. Per bug 488949 comment 3 (and the end of 4), someone with JS skills can probably hook up to the stringbundle service to pull strings that are currently in crashes.dtd from our Cocoa global_locale_crashes_properties.strings file and then use JS DOM manipulation to replace the entities in the file with those strings.

If we have any JS-savvy takers before b3, we can do this.

Comment 1

[Christopher Henderson]

Attachment: Fix v1.0

Removes the crashes.dtd placeholders and adds id attributes to the relevant elements. Adds the insertLocalizedStrings() method that grabs strings from the stringbundle service and inserts them using the innerHTML property. Puts the strings from crashes.dtd into global_locale_crashes_properties.strings.in.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 376397 [details] [diff] [review]
Fix v1.0

I've tested this, and it works as expected.

Comment 3

[Stuart Morgan]

Comment on attachment 376397 [details] [diff] [review]
Fix v1.0

>+  var bundles = Cc["@mozilla.org/intl/stringbundle;1"].
>+                getService(Ci.nsIStringBundleService);

Why break this line but not the equally-long lines right after it? Break them
(at the =) or don't break this line.

>+<p id="noReports" style="display: none">;</p>

Remove the stray ';'

sr=smorgan otherwise.

Comment 4

[Christopher Henderson]

Attachment: Fix v1.1, for checkin

Patch for checkin, with sr comments addressed.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in; thanks again, hendy!