489518 - Buttons in initial pop-up window are not visible in firefox in ce6.

Status: VERIFIED FIXED

(Core :: General, defect)

Description

[ANAND]

User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; GTB5; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; Zune 3.0)
Build Identifier: firefox-ce6-0415-1

After starting firefox.exe,YES/NO buttons in pop-up that asks for "making firefox as your default browser" are not visible.
screenshot here.
http://s619.photobucket.com/albums/tt271/nvtestacc/?action=view&current=firefox_pop.jpg

Reproducible: Always

Steps to Reproduce:
1.Run firefox.exe from "firefox-ce6-0415-1" version.
2.An mssg appears on device asking "do you want to make firefox as your default browser" 
3.Tabs for "Yes/No" in pop-up are not visible

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: add title bar height as necessary

This should fix it.  On CE, apparently the window size for popups with SYSMENU includes the title bar, not leaving that space available for applications to draw on.  Under desktop Win32, it's not counted.

Also, I'd always wondered why we had the GetHeight() function there.  Now I know.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 376581 [details] [diff] [review]
add title bar height as necessary

Do we really need to cache mExtraHeight?

Comment 4

[timeless]

Attachment: example of current truncation from winCE

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: don't bother caching

Good point; computing the window style is cheap, and this isn't performance critical.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This was checked in.

Comment 7

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Windows; U; WindowsCE 6.0; en-US; rv:1.9.2a2pre) Gecko/20090810 Minefield/3.6a2pre