489775 - CSV data link raises an exception on new graph server

Status: RESOLVED INCOMPLETE

(Webtools Graveyard :: Graph Server, defect)

Description

[Chris AtLee [:catlee]]

If you clink on the "CSV data" link on a page in the new graph server, you're given some python exception output:

Traceback (most recent call last):
  File "/data/graphs-new/server/dumpdata.cgi", line 26, in ?
    id = int(id)
TypeError: int() argument must be a string or a number

Comment 3

[Robert Helmer [:rhelmer]]

Looks like the "legacy URL" handling in here doesn't do quite the right thing:
http://hg.mozilla.org/graphs/file/2dccd5b21ac8/server/dumpdata.cgi#l21

Also, looks like each series would need to be sent as a separate request, the current implementation just wants a single id.

The quick fix here to get it back to how it used to be is to change URLs of the form:

http://graphs.mozilla.org/server/dumpdata.cgi?show=31-1-97&sel=1279288460,1289485268
to:
http://graphs.mozilla.org/server/dumpdata.cgi?id=31&sel=1279288460,1289485268

Might as well fix the parsing of "legacy" URLs too.

I think we should also either return a CSV containing all data series, or one CSV for each data series (probably the former). I'll file a separate bug on that, it looks like the "legacy" URLs supported that, I might dig in the history to find out more about how this used to be. This feature will probably be only for 2.0

Comment 4

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.