Closed Bug 489913 Opened 13 years ago Closed 13 years ago

Better documentation for signature/vCard attributes in nsIMsgIdentity.idl

Categories

(MailNews Core :: Backend, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

Details

Attachments

(1 file, 1 obsolete file)

This is trivial (no code changes, just comments) but should be fixed to avoid confusion. While the comments for the new attributes introduced in bug 324495 may not have been optimal, the drive-by changes made in bug 167319 introduced a wrong reference and made the values of the boolean pref ambiguous. I can imagine that signature-related extensions will need to be updated, where it may be tricky to figure out what those attributes mean based on the current comments. Thus, I'm trying to get it right in the third attempt now. I've also looked into the related signature/vCard attributes, but not into any of the attributes used outside of that scope which may not be documented yet.
Attached patch Proposed changes (obsolete) — Splinter Review
This simple patch corrects and modifies the signature-related comments to be more informative, and also adds a comment for the escapedVCard attribute. It doesn't modify any attribute or function. I'm not certain if a new UUID has to be generated to ensure that the changes are correctly recognized, but I figured it cannot hurt.
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
Attachment #374386 - Flags: superreview?(bienvenu)
Attachment #374386 - Flags: review?(mnyromyr)
Comment on attachment 374386 [details] [diff] [review]
Proposed changes

you definitely don't want to rev the UUID here. Other than that, sr=me
Attachment #374386 - Flags: superreview?(bienvenu) → superreview+
Thanks, that was quick. Revised version without changing the UUID.
Attachment #374386 - Attachment is obsolete: true
Attachment #374390 - Flags: superreview+
Attachment #374390 - Flags: review?(mnyromyr)
Attachment #374386 - Flags: review?(mnyromyr)
Comment on attachment 374390 [details] [diff] [review]
Proposed changes (v2)
[Checkin: Comment 6]

Wow, I never was aware what show-jumping course my plain text sig has to hop through... ;-)
Attachment #374390 - Flags: review?(mnyromyr) → review+
:-)

Push for comm-central, please.
Keywords: checkin-needed
Whiteboard: [c-n: comm-central]
Attachment #374390 - Attachment description: Proposed changes (v2) → Proposed changes (v2) [Checkin: Comment 6]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-litmus-
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: comm-central]
Target Milestone: --- → Thunderbird 3.0b3
You need to log in before you can comment on or make changes to this bug.