490105 - Long strings in autoconfig need to wrap

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Phil Ringnalda (:philor)]

From bug 422814 comment 134:

[[[
Failure to log in breaks the dialog. With the goats@/goats, hit "Create
account" and the failure to log in puts up a "FAIL" dialog, but also shoves the
right side of the main window over a little with an "Username or password
invalid" (which I bet is then a huge shove with a language where that has to be
longer), and shoves the "Edit" and "Create Account" buttons halfway out of
sight, because the "Configuration could not be verified -- is the username or
password wrong?" string is too long and not wrapping, which probably means that
things are broken for more than just that one string in more verbose locales
than English.
]]]

where the STR for goats are

1. File - New - Mail Account (Quick Setup)
2. Name = goats, email = [e-mail], password = goats (I really hope the account doesn't exist)
3. Next, then when the servers are discovered, Create account

Comment 2

[Magnus Melin [:mkmelin]]

This sounds like it should block.

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

This is probably mine with bug 490097

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

assigning this over to bwinton who's going to rock out where I'm obviously not

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Attachment: Wrapped error message.

Ta-da!

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Attachment: [checked in] A small patch to get the error message to wrap.

Well, that ended up being a small change.

clarkbw gave a ui-review+ over IRC.

Comment 8

[Phil Ringnalda (:philor)]

Comment on attachment 382374 [details] [diff] [review]
[checked in] A small patch to get the error message to wrap.

Yup, looks good. I thought we still needed to wrap the one on the left side, but when I tried with a l10n-approximation with the longest words I could find for username, password and invalid, I figured it looked better pushing than it would with two words on one line and one on the next.

Comment 9

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/68e9bf53a79c