Decide what we're doing with dump/ddump in autoconfig, and clean them up

RESOLVED FIXED in Thunderbird 3.0b4

Status

Thunderbird
Account Manager
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: philor, Assigned: philor)

Tracking

Trunk
Thunderbird 3.0b4

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Assignee)

Description

9 years ago
Autoconfig code has a few dump()s that snuck in, a ton of ddump()s, which are a dump() as long as kDebug is true, and currently it's set by a "let kDebug = true;" so we're rather noisy.

emailWizard.js also does log4moz logging, as well as ddump() logging, as well as dump() logging.

What we need is some sanity: ideally all pretty shiny carefully thought out log4moz with the things that someone only cared about for a little while when they were working on something removed, but at the very least all ddump() instead of dump() with kDebug set off a pref rather than just always on.
(Assignee)

Comment 1

9 years ago
Created attachment 374712 [details] [diff] [review]
emailWizard.js hunk - checked in

Drops emailWizard.js down from three ways to dump to just one, and fixes a few of the missing spaces and typos that were getting on my nerves. If any of the ones I killed were things you want, I can log4moz them instead, but they looked pretty temporary.
Attachment #374712 - Flags: review?(bienvenu)

Comment 2

9 years ago
Comment on attachment 374712 [details] [diff] [review]
emailWizard.js hunk - checked in

thx for cleaning this up.
Attachment #374712 - Flags: review?(bienvenu) → review+
(Assignee)

Comment 3

9 years ago
Comment on attachment 374712 [details] [diff] [review]
emailWizard.js hunk - checked in

http://hg.mozilla.org/comm-central/rev/fcb4e943da8e
Attachment #374712 - Attachment description: emailWizard.js hunk → emailWizard.js hunk - checked in
(Assignee)

Comment 4

8 years ago
Created attachment 397552 [details] [diff] [review]
Shush ddump - checked in

Considerably easier to just shut them up by default, rather than deciding about the value and correct destination of every ddump.
Attachment #397552 - Flags: review?(bienvenu)

Comment 5

8 years ago
Comment on attachment 397552 [details] [diff] [review]
Shush ddump - checked in

yeah, this shouldn't have snuck in.
Attachment #397552 - Flags: review?(bienvenu) → review+
(Assignee)

Comment 6

8 years ago
Comment on attachment 397552 [details] [diff] [review]
Shush ddump - checked in

http://hg.mozilla.org/comm-central/rev/b6392cba3b7d
Attachment #397552 - Attachment description: Shush ddump → Shush ddump - checked in
Created attachment 397694 [details] [diff] [review]
A patch to fix some javascript errors when kDebug is false.

Attachment 397552 [details] [diff] seems to break the emailWizard.js at:
http://mxr.mozilla.org/comm-central/source/mailnews/base/prefs/content/accountcreation/emailWizard.js#78
with the following messages:

JavaScript strict warning: chrome://messenger/content/accountcreation/emailWizard.js, line 91: assignment to undeclared variable getElementById

JavaScript error: , line 0: uncaught exception: [Exception... "Illegal operation on WrappedNative prototype object"  nsresult: "0x8057000c (NS_ERROR_XPC_BAD_OP_ON_WN_PROTO)"  location: "JS frame :: chrome://messenger/content/accountcreation/emailWizard.js :: anonymous :: line 134"  data: no]

JavaScript error: , line 0: uncaught exception: [Exception... "Illegal operation on WrappedNative prototype object"  nsresult: "0x8057000c (NS_ERROR_XPC_BAD_OP_ON_WN_PROTO)"  location: "JS frame :: chrome://messenger/content/accountcreation/emailWizard.js :: anonymous :: line 311"  data: no]

and others like them.

Here's a patch to get the new account wizard working again.

Thanks,
Blake.
Attachment #397694 - Flags: review?(philringnalda)
Created attachment 397704 [details] [diff] [review]
A patch to implement philor's suggestion of removing the function entirely.

There you go.
Attachment #397694 - Attachment is obsolete: true
Attachment #397704 - Flags: review?(philringnalda)
Attachment #397694 - Flags: review?(philringnalda)
(Assignee)

Comment 9

8 years ago
Created attachment 397798 [details] [diff] [review]
With more wrapping

r=me, thanks. I added some more wrapping of long lines while I was waiting for the tree to green up, but it doesn't look like it's going to make it tonight.
Attachment #397704 - Attachment is obsolete: true
Attachment #397798 - Flags: review+
Attachment #397704 - Flags: review?(philringnalda)
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/12460d9e985b
Assignee: nobody → philringnalda
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b4
You need to log in before you can comment on or make changes to this bug.