Closed
Bug 490111
Opened 15 years ago
Closed 15 years ago
Decide what we're doing with dump/ddump in autoconfig, and clean them up
Categories
(Thunderbird :: Account Manager, defect)
Thunderbird
Account Manager
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b4
People
(Reporter: philor, Assigned: philor)
References
Details
Attachments
(3 files, 2 obsolete files)
7.62 KB,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
674 bytes,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
18.25 KB,
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
Autoconfig code has a few dump()s that snuck in, a ton of ddump()s, which are a dump() as long as kDebug is true, and currently it's set by a "let kDebug = true;" so we're rather noisy. emailWizard.js also does log4moz logging, as well as ddump() logging, as well as dump() logging. What we need is some sanity: ideally all pretty shiny carefully thought out log4moz with the things that someone only cared about for a little while when they were working on something removed, but at the very least all ddump() instead of dump() with kDebug set off a pref rather than just always on.
Assignee | ||
Comment 1•15 years ago
|
||
Drops emailWizard.js down from three ways to dump to just one, and fixes a few of the missing spaces and typos that were getting on my nerves. If any of the ones I killed were things you want, I can log4moz them instead, but they looked pretty temporary.
Attachment #374712 -
Flags: review?(bienvenu)
Comment 2•15 years ago
|
||
Comment on attachment 374712 [details] [diff] [review] emailWizard.js hunk - checked in thx for cleaning this up.
Attachment #374712 -
Flags: review?(bienvenu) → review+
Assignee | ||
Comment 3•15 years ago
|
||
Comment on attachment 374712 [details] [diff] [review] emailWizard.js hunk - checked in http://hg.mozilla.org/comm-central/rev/fcb4e943da8e
Attachment #374712 -
Attachment description: emailWizard.js hunk → emailWizard.js hunk - checked in
Assignee | ||
Comment 4•15 years ago
|
||
Considerably easier to just shut them up by default, rather than deciding about the value and correct destination of every ddump.
Attachment #397552 -
Flags: review?(bienvenu)
Comment 5•15 years ago
|
||
Comment on attachment 397552 [details] [diff] [review] Shush ddump - checked in yeah, this shouldn't have snuck in.
Attachment #397552 -
Flags: review?(bienvenu) → review+
Assignee | ||
Comment 6•15 years ago
|
||
Comment on attachment 397552 [details] [diff] [review] Shush ddump - checked in http://hg.mozilla.org/comm-central/rev/b6392cba3b7d
Attachment #397552 -
Attachment description: Shush ddump → Shush ddump - checked in
Comment 7•15 years ago
|
||
Attachment 397552 [details] [diff] seems to break the emailWizard.js at: http://mxr.mozilla.org/comm-central/source/mailnews/base/prefs/content/accountcreation/emailWizard.js#78 with the following messages: JavaScript strict warning: chrome://messenger/content/accountcreation/emailWizard.js, line 91: assignment to undeclared variable getElementById JavaScript error: , line 0: uncaught exception: [Exception... "Illegal operation on WrappedNative prototype object" nsresult: "0x8057000c (NS_ERROR_XPC_BAD_OP_ON_WN_PROTO)" location: "JS frame :: chrome://messenger/content/accountcreation/emailWizard.js :: anonymous :: line 134" data: no] JavaScript error: , line 0: uncaught exception: [Exception... "Illegal operation on WrappedNative prototype object" nsresult: "0x8057000c (NS_ERROR_XPC_BAD_OP_ON_WN_PROTO)" location: "JS frame :: chrome://messenger/content/accountcreation/emailWizard.js :: anonymous :: line 311" data: no] and others like them. Here's a patch to get the new account wizard working again. Thanks, Blake.
Attachment #397694 -
Flags: review?(philringnalda)
Comment 8•15 years ago
|
||
There you go.
Attachment #397694 -
Attachment is obsolete: true
Attachment #397704 -
Flags: review?(philringnalda)
Attachment #397694 -
Flags: review?(philringnalda)
Assignee | ||
Comment 9•15 years ago
|
||
r=me, thanks. I added some more wrapping of long lines while I was waiting for the tree to green up, but it doesn't look like it's going to make it tonight.
Attachment #397704 -
Attachment is obsolete: true
Attachment #397798 -
Flags: review+
Attachment #397704 -
Flags: review?(philringnalda)
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Comment 10•15 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/12460d9e985b
Assignee: nobody → philringnalda
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Updated•15 years ago
|
Target Milestone: --- → Thunderbird 3.0b4
You need to log in
before you can comment on or make changes to this bug.
Description
•