490113 - Clean up autoconfig button styles

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Phil Ringnalda (:philor)]

From bug 422814 comment 139:

[[[
Note to self: don't forget that .larger-button looks like pure evil except for
pinstripe which doesn't style it, and that the style on #back_button to make it
look disabled when it isn't disabled is... not entirely in line with typical UI
guidelines.
]]]

Had I gotten that far before running back to the warm comfort of Pinstripe, which isn't styling the buttons, I would also have whined about the edit/go/stop buttons being too small (as bienvenu pointed out somewhere farther down the bug).

I'm not sure one way or the other whether we need to emphasize the next button, de-emphasize edit/go/stop, and severely de-emphasize back, but if we do, we need to do it in a more subtle way that doesn't scream "something's wrong here, like maybe the CSS didn't apply or I'm missing a font!" and doesn't make an enabled button look like it's disabled.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Sort of surprised me that the bold was actually most of what made them scream at you, but I'm sort of hoping that a little bit less-bigger and less-smaller will cut down on the number of bugs people will file thinking that something's wrong with them. (And no, I don't know why 1.1em is just noticeably bigger, but 0.9em is invisibly smaller and needs to be 0.85em.)

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 379834 [details] [diff] [review]
Fix v.1

thanks!  this does look a lot better

Comment 3

[Phil Ringnalda (:philor)]

http://build.mozillamessaging.com/mercurial/comm-central/rev/70a68603014e