Closed Bug 490115 Opened 12 years ago Closed 12 years ago

Finding that the outgoing server exists calls for using it, not alert()ing about it

Categories

(Thunderbird :: Account Manager, defect)

Product:
Thunderbird
Component:
Account Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.0b3

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file)

Like so?
3.75 KB, patch
Bienvenu
: review+
Details | Diff | Splinter Review 
In emailWizard.js::validateAndFinish, when we find that this.checkOutgoingAccountIsNew() returns false because the SMTP account already exists, we alertPrompt() about it, which is totally the wrong thing to do: far and away the most likely reason we're getting there (remember, we've already passed checkIncomingAccountIsNew()) is because someone created an account, then for whatever reason deleted the incoming server without knowing to go to a separate place to delete the outgoing account. If we find that the outgoing server we want to create already exists, then the reasonable thing to do is to *use* it, not yelp about it.
Flags: blocking-thunderbird3?
Phil Ringnalda, will this bug resolve problem of Bug 170520 Comment #52?
That has nothing at all to do with this.
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Attached patch Like so? — — Splinter Review 
This seems to work.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #376639 - Flags: review?(bienvenu)
Attachment #376639 - Flags: review?(bienvenu) → review+
Comment on attachment 376639 [details] [diff] [review]
Like so?

works here, thx!
http://hg.mozilla.org/comm-central/rev/74b19b4d9976
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
You need to log in before you can comment on or make changes to this bug.