490253 - TestAUSReadStrings.cpp: fix nits in result reports

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[Serge Gautherie (:sgautherie)]

*s/TEST-FAIL/TEST-UNEXPECTED-FAIL/.
*Remove "*** " in "*** TEST-*".

Maybe try and use TestHarness.h features...

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 384822 [details] [diff] [review]
patch rev1


r=me
with same kind of (follow-up) nits as in bug 490258.

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2 - uses TestHarness.h

Serge, what is the best example of using TestHarness.h in regards to logging?

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 385194 [details] [diff] [review]
patch rev2 - uses TestHarness.h

Nits:

>diff --git a/toolkit/mozapps/update/test/TestAUSReadStrings.cpp >@@ -62,113 +62,107 @@
> #include <stdio.h>

Remove it: TestHarness.h has it.

> #include <string.h>

(Can you check/try if this one could be removed?)

*****

(In reply to comment #3)
> Serge, what is the best example of using TestHarness.h in regards to logging?

I don't know (if there is one) (yet):
I noticed this file only "recently" and it has room for (logging) improvements...

Comment 5

[Robert Strong (they/them - no direct email)]

(In reply to comment #4)
> (From update of attachment 385194 [details] [diff] [review])
> Nits:
> 
> >diff --git a/toolkit/mozapps/update/test/TestAUSReadStrings.cpp >@@ -62,113 +62,107 @@
> > #include <stdio.h>
> 
> Remove it: TestHarness.h has it.
Will do
 
> > #include <string.h>
> 
> (Can you check/try if this one could be removed?)
I verified it was needed when I wrote the test

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: patch as checked in

Comment 7

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/88abbc95d310

Comment 8

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9e38062a9f25

Comment 9

[Robert Strong (they/them - no direct email)]

Attachment: patch as pushed to mozilla-1.9.1

Comment 10

[juan becerra [:juanb]]

Serge, Robert, could you help us verify this bug fix for 3.5.2?

Comment 11

[Robert Strong (they/them - no direct email)]

hmmm... this just changed output for a test. Instead of QA verifying perhaps Serge could verify it?

Comment 12

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1249058643.1249065464.2782.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/07/31 09:44:03
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1249052539.1249059845.4307.gz&fulltext=1
WINNT 5.2 mozilla-1.9.1 unit test on 2009/07/31 08:02:19
{
Running TestAUSReadStrings tests
TEST-PASS | Updater ReadStrings | all checks passed
}