503308 - Debug build failure in toolkit/mozapps/update/TestAUSReadStrings.cpp: undefined reference to `NS_DebugBreak'

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[Simon Montagu :smontagu]

c++   -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -pedantic -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DDEBUG -D_DEBUG -DDEBUG_smontagu -DTRACING -g -fno-inline -o TestAUSReadStrings TestAUSReadStrings.o   -lpthread          -Wl,-rpath-link,/home/smontagu/mozwork/hg/obj-i686-pc-linux-gnu-debug/dist/bin -Wl,-rpath-link,/usr/local/lib -L../../../../dist/bin -L../../../../dist/lib ../../../../toolkit/mozapps/update/src/updater/readstrings.o  -lasound -ldl -lm     
TestAUSReadStrings.o: In function `_PlatformDeinitProfiler':
/home/smontagu/mozwork/hg/xpcom/tests/TestHarness.h:224: undefined reference to `NS_DebugBreak'
TestAUSReadStrings.o: In function `_PlatformStopProfile':
/home/smontagu/mozwork/hg/xpcom/tests/TestHarness.h:218: undefined reference to `NS_DebugBreak'
TestAUSReadStrings.o: In function `_PlatformStartProfile':
/home/smontagu/mozwork/hg/xpcom/tests/TestHarness.h:212: undefined reference to `NS_DebugBreak'
TestAUSReadStrings.o: In function `_PlatformInitProfiler':
/home/smontagu/mozwork/hg/xpcom/tests/TestHarness.h:206: undefined reference to `NS_DebugBreak'
TestAUSReadStrings.o: In function `StopProfiling':
/home/smontagu/mozwork/hg/xpcom/tests/TestHarness.h:149: undefined reference to `NS_DebugBreak'
TestAUSReadStrings.o:/home/smontagu/mozwork/hg/xpcom/tests/TestHarness.h:153: more undefined references to `NS_DebugBreak' follow
collect2: ld returned 1 exit status
make: *** [TestAUSReadStrings] Error 1

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/2afd49118d1b

Comment 3

[Robert Strong (they/them - no direct email)]

backed out

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch - passed try server (checked in)

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 387718 [details] [diff] [review]
patch - passed try server (checked in)

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/03dee9517102

Comment 6

[Robert Strong (they/them - no direct email)]

I'm going to leave open until I verify there are no problems which there shouldn't be since the patch passed the try server and I built it locally for Fennec on Windows Mobile as well.

Comment 7

[Justin Lebar (not reading bugmail)]

Works for me.

Comment 8

[Serge Gautherie (:sgautherie)]

Oh. What is the issue here? That Toolkit can't depend on Xpcom?

Comment 9

[Robert Strong (they/them - no direct email)]

I don't know the specific dependencies involved but TestAUSReadStrings doesn't need / use xpcom, etc. and TestHarness.h does which caused missing dependencies.

Resolving -> fixed

Comment 10

[Robert Strong (they/them - no direct email)]

Note: I added this fix when I pushed bug 490253 to mozilla-1.9.1