490479 - Exception when trying to view smart folders (chrome://messenger/content/folderPane.js Line 849)

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Stefan Plewako [:stef]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4
Build Identifier: 

When I'm trying to display smart folders in folder pane nothing happens (last mode is displayed under changed label) and I'm getting following error in error console:

Błąd: uncaught exception: [Exception... "Component returned failure code: 0x80550013 [nsIMsgFolder.addSubfolder]"  nsresult: "0x80550013 (<unknown>)"  location: "JS frame :: chrome://messenger/content/folderPane.js :: ftv_createVFFolder :: line 849"  data: no]


Reproducible: Always

Steps to Reproduce:
1. Download tb nightly
2. Add predefined gmail account
3. Switch folder pane to smart folders mode



Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9.1b5pre) Gecko/20090428 Shredder/3.0b3pre
BuildID=20090428030602

Comment 1

[David :Bienvenu]

I'll try this - was this a new profile with no accounts, or did you add the gmail account to an existing profile with existing accounts?

Comment 2

[WADA:World Anti-bad-Duping Agency]

Bug 490749 is relevant to this bug?
Bug 490749 is for exception in folderPane.js upon File/New/Saved Search when no account/no folder is selected at folder pane.

Comment 3

[Stefan Plewako [:stef]]

(In reply to comment #1)
> I'll try this - was this a new profile with no accounts, or did you add the
> gmail account to an existing profile with existing accounts?

spotted with old profile (gmail imap, rss, nntp, ...) and rerpo with fresh one (only gmail imap)

Comment 4

[WADA:World Anti-bad-Duping Agency]

> Steps to Reproduce:
>(snip)
> 2. Add predefined gmail account
> 3. Switch folder pane to smart folders mode

Did you access Gmail IMAP server(click Inbox of the new Gmail IMAP account) after step 2, before step 3?

Comment 5

[Stefan Plewako [:stef]]

Yes, after complete Inbox sync (and some other folders).

Comment 6

[Stefan Plewako [:stef]]

OK, it looks like more general, not gmail specific problem - I get the same with pop3 account, and/or pop3 + gmail imap... the smart inboxes folder exist on disk, I'm testing this with recent localized (pl, but I don't see any difference when testing en-US ones) nightlies under Fedora 11pre/rawhide (earlier F10).

Comment 7

[David :Bienvenu]

do you have any extensions installed?

Comment 8

[Stefan Plewako [:stef]]

(In reply to comment #7)
> do you have any extensions installed?

Lightning only (but not on fresh profiles).

Comment 9

[Alex Ihrig [:Thunderbird_Mail_DE]]

Confirming this bug for old and new, clean profiles. Error occurs for POP + IMAP accounts.

Now I've been testing en-US builds from 20090428 - 20090507. They're all working for me?! Switching back to a localized (de) 20090507 build leads to the described bug?!

BTW: If Smart Folders is the first folder pane mode after starting Thunderbird, all other pane modes fail, too.

Comment 10

[Alex Ihrig [:Thunderbird_Mail_DE]]

(In reply to comment #9)
So maybe a problem width special folder names in l10n builds?

Comment 11

[David :Bienvenu]

(In reply to comment #10)
> (In reply to comment #9)
> So maybe a problem width special folder names in l10n builds?

That would explain it - Ludovic, do you see a similar issue running a non-English build?

Comment 12

[Stefan Plewako [:stef]]

Also affects Windows XP.

Comment 13

[Ludovic Hirlimann [:Usul]]

(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > So maybe a problem width special folder names in l10n builds?
> 
> That would explain it - Ludovic, do you see a similar issue running a
> non-English build?

French build does.

Comment 14

[Alex Ihrig [:Thunderbird_Mail_DE]]

I've now changed the special folder names in messenger.properties to the original en-US strings. That doesn't resolve the problem.

Comment 15

[Alex Ihrig [:Thunderbird_Mail_DE]]

> I've now changed the special folder names in messenger.properties to the
> original en-US strings. That doesn't resolve the problem.

Mhh, I've to correct this. Removing only the intl. characters (umlauts) in German Special folder names doesn't resolve the problem. But replacing the whole special folder names with the en-US ones does resolve the problem. 
So I've done some more replacing tests with these strings. It seems, only the inbox can use the localized string. All other special folder strings lead to the error, if they use another name than the en-US one, although they don't include special characters like umlauts.

Strange is one more thing. Although I can use the German "Posteingang" (inbox) string in messenger.properties for this test, the special folder inbox uses only in the normal folders tree the German string. In the Smart folders tree it uses still "Inbox".

Comment 16

[Mark Banner (:standard8)]

Given this appears to be a l10n issue (comment 13) granting blocking. bienvenu - can you take a closer look at this?

Comment 17

[David :Bienvenu]

that error is NS_MSG_FOLDER_EXISTS, so our find is failing, even though the folder does exist, which could be a mismatch between what we're looking for, and what we're trying to create.

Comment 18

[David :Bienvenu]

Attachment: proposed fix

I haven't tried this with a localized build, but I think it will fix the problem. It doesn't break the English build.

Comment 19

[Phil Ringnalda (:philor)]

Comment on attachment 377056 [details] [diff] [review]
proposed fix

Dossiers virtuels looks just fine, nothing in console d'erreurs.

Comment 20

[Alex Ihrig [:Thunderbird_Mail_DE]]

Confirming; patch is working without error in German build.

Comment 21

[Alex Ihrig [:Thunderbird_Mail_DE]]

(In reply to comment #15)
> Strange is one more thing. Although I can use the German "Posteingang" (inbox)
> string in messenger.properties for this test, the special folder inbox uses
> only in the normal folders tree the German string. In the Smart folders tree it
> uses still "Inbox".

This is sill a bug. In all "normal" account/folder trees, the l10n string for "inbox" is used, but in the smart folders tree it still remains as "Inbox". All other special folders are (with the patch applied) using the correct l10n string in smart folders.

Comment 22

[David :Bienvenu]

Ihrig, can you file a new bug for the non-localized Inbox name? Actually, that might be a bit of a dup, but maybe not.

Thx to folks for verifying the fix. Fix checked in.

Comment 23

[Alex Ihrig [:Thunderbird_Mail_DE]]

(In reply to comment #22)
> Ihrig, can you file a new bug for the non-localized Inbox name?

Done:
https://bugzilla.mozilla.org/show_bug.cgi?id=492739