490691 - in smart folders mode, remove special folders from normal accounts

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[David :Bienvenu]

Attachment: proposed fix

Since we're showing you your special folders in the smart folders account, we can hide them from their actual accounts.

This is slightly tricky, because we then need to promote children of the Inbox to top level folders in the actual accounts (we hide children of the inbox from the smart folders account). So I had to add a subclass of ftvItem that knows not to include special folders in its children, and to add sub-folders of the inbox to its children as top level folders.

Once I did this, it became clear that I should add a smart folder for the spam folders, so I've done that as well.

Comment 1

[David Ascher (:davida)]

My memory of the plan was that the special folders would be top-level, not inside a 'special folders' top-node.  Is that hard?

Comment 2

[David :Bienvenu]

I don't think it would be hard (famous last words), but it makes it very hard to collapse them away - I can try adding that to this patch.

Comment 3

[David :Bienvenu]

Attachment: remove special folders, and remove special folder account

Comment 4

[David :Bienvenu]

One thing I'm not clear on is where the gloda saved searches will go in this UI - will they be top level folders as well? If you get a lot of them, you might want to occasionally collapse them away...

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> One thing I'm not clear on is where the gloda saved searches will go in this UI
> - will they be top level folders as well? If you get a lot of them, you might
> want to occasionally collapse them away...

Does this need resolving before I review this patch? Bryan?

Comment 6

[David :Bienvenu]

(In reply to comment #5)
> (In reply to comment #4)
> > One thing I'm not clear on is where the gloda saved searches will go in this UI
> > - will they be top level folders as well? If you get a lot of them, you might
> > want to occasionally collapse them away...
> 
> Does this need resolving before I review this patch? Bryan?

I'm pretty sure Bryan and David want the smart folders at the top level...

Comment 7

[David Ascher (:davida)]

IMO, this doesn't need resolving.  gloda saved searches will show up either toplevel or in a "recent & saved searches" toplevel, or something.  but let's not hold this generic patch for that specific bit.

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 375081 [details] [diff] [review]
remove special folders, and remove special folder account

ah, sorry.

I think bienvenu makes a good point that lots of smart folders at the top level might mean that people want to collapse them but I don't think we want to block on that need right now.

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 375081 [details] [diff] [review]
remove special folders, and remove special folder account

In general the patch looks good. However unfortunately its bitrotted, I tried fixing it but got some exception on startup. Can you take a look?

Comment 10

[David :Bienvenu]

Attachment: un-bitrotted patch

yuck, that was bit-rotted - I'm impressed you even tried to de-bitrot it :-) I didn't get any startup errors running with this patch.

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 378598 [details] [diff] [review]
un-bitrotted patch

The only issue I've seen is when we create a new account we get the Inbox listed under the account and the Inbox smart folder. That's not really a big issue so I'm happy if you want to ship that out to another bug to fix.

r=Standard8 with either a bug or a fix for the issue mentioned.

Comment 12

[David :Bienvenu]

 Bug 493960 filed for the new account inbox issue.

Comment 13

[David :Bienvenu]

fix checked in.