Closed Bug 490887 Opened 16 years ago Closed 16 years ago

Update add-on listing page with new look

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

x86
All
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: osunick, Assigned: rdoherty)

References

()

Details

Attachments

(3 files, 1 obsolete file)

waiting on clearleft assets before we can proceed with this
Target Milestone: --- → 5.0.6
Priority: -- → P1
Assignee: nobody → nat
This will get reassigned to lorchard once we have CSS + header + footer.
Depends on: 490889
Attached image final mockup
Whiteboard: ->lorchard
Blocks: 492151
CSS is being added in bug 490887 but we can start on this
Assignee: nat → rdoherty
Whiteboard: ->lorchard
I got too excited - we're still waiting on clearleft for this.
(In reply to comment #5) > I got too excited - we're still waiting on clearleft for this. I see some of the CSS/HTML needed is done, but a few things are missing. I can probably get working on it soon.
(In reply to comment #3) > Created an attachment (id=375876) [details] > final mockup I see something really similar in http://mozilla-dev.clearleft.com/pattern-portfolio.php (about 1/2 way down). Is that supposed to be the same module? It looks like it has almost all the same info, just a different layout.
After talking with Justin, it appears Clearleft has not implemented the new design yet. I am blocked on this bug.
Nick or Fligtar - anybody considered working with mozdev and/or plugindoc to get more useful information here?
(In reply to comment #8) > After talking with Justin, it appears Clearleft has not implemented the new > design yet. I am blocked on this bug. After talking with Nick, I will write the new css for the layout.
Attached patch v1 (obsolete) — Splinter Review
First patch, could definitely use a review. This does not have the install button, which is proving problematic. Requesting Les' advice since he wrote the new install button code. Not sure how to pull in the required information for it with addon->find().
Attachment #378905 - Flags: review?(lorchard)
Attachment #378905 - Flags: review?(lorchard)
Hmm... I didn't write new install button code, so much as I copied it from the original and then tweaked a little as possible in the markup so as not to break it functionally. I still don't entirely understand how it works. :(
Noticed this in main-mozilla.css, which is breaking layout in a few spots - most notably in the register/login header: p { clear: both; }
Attached patch v2Splinter Review
Attachment #378905 - Attachment is obsolete: true
Attachment #378947 - Flags: review?(lorchard)
I'm seeing this warning/error: Notice: Undefined index: compatible_apps in /Users/lorchard/devel/mozilla/addons/site/app/views/elements/amo2009/install.thtml on line 58 Also, I'm running Fx3.5b4. I found an addon on the front page that said "This add-on is for older versions of Firefox", but the install button on the detail page is plain old "Add to Firefox". Thinking the missing compatible_apps data is borking something. Not sure how to fix that - looks like home() is using Addon->getAddonList, while detail() is using Addon->find(). You might want to try using Addon->getAddon(), since it looks like it does a bunch of work to dig up other addon details used by the install button
Attachment #378947 - Flags: review?(lorchard) → review-
Attached patch v3Splinter Review
fixed compatible apps issue
Attachment #379171 - Flags: review?(lorchard)
Attachment #379171 - Flags: review?(lorchard) → review+
Comment on attachment 379171 [details] [diff] [review] v3 Yes, indeedy. That seems to work.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Verified FIXED; looking good on https://preview.addons.mozilla.org/en-US/firefox/addon/7431, and we've been filing smaller spinoff bugs already.
Status: RESOLVED → VERIFIED
Hmm, is there another bug for the "Related Collections" section that was implemented in bug 456140? It seems to have disappeared from the new display page.
(In reply to comment #20) > Hmm, is there another bug for the "Related Collections" section that was > implemented in bug 456140? It seems to have disappeared from the new display > page. Probably not, I was working off of the mockup attached to this bug. File a new one to get it added back in.
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: