Closed
Bug 490887
Opened 16 years ago
Closed 16 years ago
Update add-on listing page with new look
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
5.0.6
People
(Reporter: osunick, Assigned: rdoherty)
References
()
Details
Attachments
(3 files, 1 obsolete file)
603.68 KB,
image/png
|
Details | |
37.43 KB,
patch
|
lorchard
:
review-
|
Details | Diff | Splinter Review |
37.95 KB,
patch
|
lorchard
:
review+
|
Details | Diff | Splinter Review |
Layout and blocking are identical, just new look:
http://people.mozilla.com/~jscott/bandwagon/clearleft/v6/Add-on%20View%20v6.png
Reporter | ||
Comment 1•16 years ago
|
||
waiting on clearleft assets before we can proceed with this
Reporter | ||
Updated•16 years ago
|
Target Milestone: --- → 5.0.6
Reporter | ||
Updated•16 years ago
|
Priority: -- → P1
Reporter | ||
Updated•16 years ago
|
Assignee: nobody → nat
Reporter | ||
Comment 2•16 years ago
|
||
This will get reassigned to lorchard once we have CSS + header + footer.
Depends on: 490889
Comment 3•16 years ago
|
||
Updated•16 years ago
|
OS: Mac OS X → All
Updated•16 years ago
|
Whiteboard: ->lorchard
Comment 4•16 years ago
|
||
CSS is being added in bug 490887 but we can start on this
Assignee: nat → rdoherty
Whiteboard: ->lorchard
Comment 5•16 years ago
|
||
I got too excited - we're still waiting on clearleft for this.
Assignee | ||
Comment 6•16 years ago
|
||
(In reply to comment #5)
> I got too excited - we're still waiting on clearleft for this.
I see some of the CSS/HTML needed is done, but a few things are missing. I can probably get working on it soon.
Assignee | ||
Comment 7•16 years ago
|
||
(In reply to comment #3)
> Created an attachment (id=375876) [details]
> final mockup
I see something really similar in http://mozilla-dev.clearleft.com/pattern-portfolio.php (about 1/2 way down). Is that supposed to be the same module? It looks like it has almost all the same info, just a different layout.
Assignee | ||
Comment 8•16 years ago
|
||
After talking with Justin, it appears Clearleft has not implemented the new design yet. I am blocked on this bug.
Comment 9•16 years ago
|
||
Nick or Fligtar - anybody considered working with mozdev and/or plugindoc to get more useful information here?
Assignee | ||
Comment 10•16 years ago
|
||
(In reply to comment #8)
> After talking with Justin, it appears Clearleft has not implemented the new
> design yet. I am blocked on this bug.
After talking with Nick, I will write the new css for the layout.
Assignee | ||
Comment 11•16 years ago
|
||
First patch, could definitely use a review.
This does not have the install button, which is proving problematic. Requesting Les' advice since he wrote the new install button code. Not sure how to pull in the required information for it with addon->find().
Attachment #378905 -
Flags: review?(lorchard)
Assignee | ||
Updated•16 years ago
|
Attachment #378905 -
Flags: review?(lorchard)
Comment 12•16 years ago
|
||
Hmm... I didn't write new install button code, so much as I copied it from the original and then tweaked a little as possible in the markup so as not to break it functionally. I still don't entirely understand how it works. :(
Comment 13•16 years ago
|
||
Noticed this in main-mozilla.css, which is breaking layout in a few spots - most notably in the register/login header:
p {
clear: both;
}
Assignee | ||
Comment 14•16 years ago
|
||
Attachment #378905 -
Attachment is obsolete: true
Attachment #378947 -
Flags: review?(lorchard)
Comment 15•16 years ago
|
||
I'm seeing this warning/error:
Notice: Undefined index: compatible_apps in /Users/lorchard/devel/mozilla/addons/site/app/views/elements/amo2009/install.thtml on line 58
Also, I'm running Fx3.5b4. I found an addon on the front page that said "This add-on is for older versions of Firefox", but the install button on the detail page is plain old "Add to Firefox".
Thinking the missing compatible_apps data is borking something. Not sure how to fix that - looks like home() is using Addon->getAddonList, while detail() is using Addon->find().
You might want to try using Addon->getAddon(), since it looks like it does a bunch of work to dig up other addon details used by the install button
Updated•16 years ago
|
Attachment #378947 -
Flags: review?(lorchard) → review-
Assignee | ||
Comment 16•16 years ago
|
||
fixed compatible apps issue
Attachment #379171 -
Flags: review?(lorchard)
Updated•16 years ago
|
Attachment #379171 -
Flags: review?(lorchard) → review+
Comment 17•16 years ago
|
||
Comment on attachment 379171 [details] [diff] [review]
v3
Yes, indeedy. That seems to work.
Assignee | ||
Comment 18•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Verified FIXED; looking good on https://preview.addons.mozilla.org/en-US/firefox/addon/7431, and we've been filing smaller spinoff bugs already.
Status: RESOLVED → VERIFIED
Comment 20•16 years ago
|
||
Hmm, is there another bug for the "Related Collections" section that was implemented in bug 456140? It seems to have disappeared from the new display page.
Assignee | ||
Comment 21•16 years ago
|
||
(In reply to comment #20)
> Hmm, is there another bug for the "Related Collections" section that was
> implemented in bug 456140? It seems to have disappeared from the new display
> page.
Probably not, I was working off of the mockup attached to this bug. File a new one to get it added back in.
Updated•10 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•