491045 - Remove support for VMS (a.k.a., OpenVMS) from NSPR

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Nelson Bolyard (seldom reads bugmail)]

Peter Weilbacher <[e-mail]> wrote:'
> Looking at bug 247933 or bug 224083 comment 5 tells me that people at HP 
> (like Colin Blake) last supported OpenVMS some time in 2003/04. 
> Last version seems to have been Mozilla 1.7.x.
> The changes to xpcom/reflect/xptcall/src/md/unix/ that became necessary
> for all platforms end of 2007 were never applied to the *vms* files, either.

So, let's remove that support.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1

Wan-Teh, I expect that, in one or more of these files, you will not want to 
make any change because the files are essentially unmodified copies of files
from third parties.  Please indicate any such files that should not be changed.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 375396 [details] [diff] [review]
patch v1 

Oops.  deleted a little too much.  :)

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v2 (checked in)

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 375400 [details] [diff] [review]
patch v2 (checked in)

Wan-Teh, 
I'm guessing you will not want to modify the autoconf files.
I have removed all the *_symvec.opt files because I believe these are only used on VMS. Please tell me if that's incorrect.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 375400 [details] [diff] [review]
patch v2 (checked in)

There's one problem with this version of the patch to the file protypes.h

-#if !defined(XP_BEOS) && !defined(VMS) \
+#if !defined(XP_BEOS)
     && !defined(_PR_AIX_HAVE_BSD_INT_TYPES)

That should have been

-#if !defined(XP_BEOS) && !defined(VMS) \
-    && !defined(_PR_AIX_HAVE_BSD_INT_TYPES)
+#if !defined(XP_BEOS) && !defined(_PR_AIX_HAVE_BSD_INT_TYPES)

I won't resubmit this entire patch just to change that.

Comment 6

[Wan-Teh Chang]

Comment on attachment 375400 [details] [diff] [review]
patch v2 (checked in)

nsprpub/build/autoconf/config.guess: OK to remove the MozillaHack section only.

Exclude nsprpub/build/autoconf/config.sub from this patch.

Thanks!

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Committed on trunk.  Watching Tinderbox.

configure;                      new revision: 1.254; previous revision: 1.253
configure.in;                   new revision: 1.259; previous revision: 1.258
build/autoconf/config.guess;    new revision: 1.17; previous revision: 1.16
config/now.c;                   new revision: 3.15; previous revision: 3.14
config/nsinstall.c;             new revision: 3.23; previous revision: 3.22
config/rules.mk;                new revision: 3.72; previous revision: 3.71
lib/ds/plds_symvec.opt; new revision: delete; previous revision: 1.2
lib/libc/src/plc_symvec.opt;    new revision: delete; previous revision: 1.2
lib/prstreams/prstrms.cpp;      new revision: 3.11; previous revision: 3.10
pr/include/md/Makefile.in;      new revision: 1.23; previous revision: 1.22
pr/include/md/_openvms.cfg;     new revision: delete; previous revision: 1.7
pr/include/md/_openvms.h;       new revision: delete; previous revision: 1.19
pr/include/md/_pth.h;           new revision: 3.35; previous revision: 3.34
pr/include/md/_unixos.h;        new revision: 3.40; previous revision: 3.39
pr/include/md/prosdep.h;        new revision: 3.22; previous revision: 3.21
pr/include/obsolete/protypes.h; new revision: 3.20; previous revision: 3.19
pr/src/nspr_symvec.opt; new revision: delete; previous revision: 1.9
pr/src/io/prmapopt.c;           new revision: 3.21; previous revision: 3.20
pr/src/io/prpolevt.c;           new revision: 3.17; previous revision: 3.16
pr/src/linking/prlink.c;        new revision: 3.101; previous revision: 3.100
pr/src/md/unix/openvms.c;       new revision: delete; previous revision: 1.9
pr/src/md/unix/unix.c;          new revision: 3.55; previous revision: 3.54
pr/src/md/unix/uxproces.c;      new revision: 3.24; previous revision: 3.23
pr/src/md/unix/uxrng.c;         new revision: 1.23; previous revision: 1.22
pr/src/misc/prnetdb.c;          new revision: 3.59; previous revision: 3.58
pr/src/pthreads/ptio.c;         new revision: 3.112; previous revision: 3.111
pr/src/pthreads/ptthread.c;     new revision: 3.83; previous revision: 3.82
pr/tests/op_filok.c;            new revision: 3.14; previous revision: 3.13

Comment 8

[Wan-Teh Chang]

I regenerated configure from configure.in using autoconf (2.13).

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.255; previous revision: 1.254
done

Comment 9

[Wan-Teh Chang]

Attachment: Delete remaining VMS code in mozilla/nsprpub/config/nsinstall.c

Found by http://mxr.mozilla.org/nspr/search?string=vms.

Comment 10

[Wan-Teh Chang]

I checked in my patch (attachment 376530 [details] [diff] [review]) on the NSPR trunk (NSPR 4.8).

Checking in nsinstall.c;
/cvsroot/mozilla/nsprpub/config/nsinstall.c,v  <--  nsinstall.c
new revision: 3.24; previous revision: 3.23
done