491359 - Even though TB can play aiff sounds as new mail alerts, you can't pick them

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Eric Shepherd [:sheppy]]

If you manually edit the sound setting to specify an AIFF file, TB does play them. However, you can't pick them using the file picker.

Comment 1

[Eric Shepherd [:sheppy]]

Attachment: Adds .aif and .aiff to supported sounds in filter

This patch allows the user to select .aif and .aiff files in the sound picker window.

Comment 2

[Eric Shepherd [:sheppy]]

I don't know if Thunderbird on Windows supports .aiff; if it doesn't, this patch would obviously need to only offer these types on Mac. Not sure how to do it conditionally based on whether or not it's a Mac though.

Comment 3

[Matt Wills]

TB 3.0b4, OSX 10.4.11:

I am unable to choose ANY new alert sound or even revert to system sound. If I switch back to TB2, I can select a sound and TB3 will honor it.

Comment 4

[Nomis101]

This is a nice little fix with no risk and would improve the life of a Mac OS X user in a great way. So I don't understand why this isn't fixed in Thunderbird 3.0? Mostly sound files on Mac OS X are AIFF (e.g. in /System/Library/Sounds), but you can't use them without converting them into WAV. I support a few Mac OS X users in questions to the new TB 3.0 and one of the most common question is "Why can't I pick AIFF files as alert sound, it's greyed out?". So I hope this will be fixed in 3.0.1 or 3.1.
I have included this patch into my unofficial builds (http://polysom.verilite.de/) so you can see, with this patch you can pick and use AIFF files as alert sound without any problem.

Comment 5

[Eric Shepherd [:sheppy]]

I'd like to propose this be taken in 3.1.

Comment 6

[David :Bienvenu]

Comment on attachment 375678 [details] [diff] [review]
Adds .aif and .aiff to supported sounds in filter

this does seem pretty trivial to me.

Comment 7

[David :Bienvenu]

Comment on attachment 375678 [details] [diff] [review]
Adds .aif and .aiff to supported sounds in filter

yeah, windows can only play .wav files. 

One way to check for the mac is to check   if if ("nsILocalFileMac" in Components.interfaces)

I don't know what the "proper" way is, perhaps using xulappinfo...

Comment 8

[David :Bienvenu]

Not blocking 3.1, but patches welcome.

Comment 9

[Mark Banner (:standard8)]

https://developer.mozilla.org/en/Toolkit_API/STEEL/steelIApplication

Application.platformIsMac

Comment 10

[Eric Shepherd [:sheppy]]

I expect to have a new patch for this today.

Comment 11

[Eric Shepherd [:sheppy]]

Attachment: [checked in] On Mac only, allow *.aif and *.aiff for new mail sounds

Now uses Application.platformIsMac to only add AIFF as a supported sound type on Mac.

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 426744 [details] [diff] [review]
[checked in] On Mac only, allow *.aif and *.aiff for new mail sounds

>+    // On Mac, allow AIFF files too
>+    
>+    if (Application.platformIsMac) {
>+      fp.appendFilter("*.aif", "*.aif");
>+      fp.appendFilter("*.aiff", "*.aiff");
>+    }

nit: no blank line required after the comment.

r=Standard8

wrt test requirement, I think we can't easily test this as it would require interaction with the platform file dialog. We'd also want to check playing of sound files which actually requires listening. So I'd suggest just having a litmus test cover this bug (I'll set the flag in a mo).

Thanks for the patch Eric, I've checked this in for you already:

http://hg.mozilla.org/comm-central/rev/23499b0b17c8

Comment 13

[Ludovic Hirlimann [:Usul]]

https://litmus.mozilla.org/show_test.cgi?id=9917