491835 - Add entry for allow/disable/remember geolocation to Permissions tab in Page Info

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Robert Kaiser]

We should add allow/disable/remember geolocation to the Permissions tab in Page Info, just as Firefox did in bug 491732. The conversion from content pref to permissions service in there sounds like a good idea as well.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 straight port [Checkin: Comment 7]

Taking bug.

> The conversion from content pref to
> permissions service in there sounds like a good idea as well.

Appears to have been fixed in some other bug.

> We should add allow/disable/remember geolocation to the Permissions tab in Page
> Info, just as Firefox did in bug 491732.

I tested this against google maps. The Google geolocation service found the right country but the wrong state and placed me right in the middle of a major highway, but I guess that's a google bug not ours.

Comment 2

[Robert Kaiser]

(In reply to comment #1)
> > The conversion from content pref to
> > permissions service in there sounds like a good idea as well.
> 
> Appears to have been fixed in some other bug.

Yes, we pulled, that into the the other one.

> > We should add allow/disable/remember geolocation to the Permissions tab in Page
> > Info, just as Firefox did in bug 491732.
> 
> I tested this against google maps. The Google geolocation service found the
> right country but the wrong state and placed me right in the middle of a major
> highway, but I guess that's a google bug not ours.

Yes, what location you get is completely up to Google.

Comment 3

[[e-mail]]

Comment on attachment 388020 [details] [diff] [review]
Patch v1.0 straight port
[Checkin: Comment 7]

Firefox are getting good at this ;-)

Comment 4

[Philip Chee]

> Firefox are getting good at this ;-)
Well I did fix the broken ARIA/focus stuff that I fixed in the rest of our Permissions tab, and that is still broken in Firefox ;-)

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> > Firefox are getting good at this ;-)
> Well I did fix the broken ARIA/focus stuff that I fixed in the rest of our
> Permissions tab, and that is still broken in Firefox ;-)

Have you filed a bug?

Comment 6

[Philip Chee]

In reply to comment #5)
> Have you filed a bug?

Filed Bug 504053

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 388020 [details] [diff] [review]
Patch v1.0 straight port
[Checkin: Comment 7]


http://hg.mozilla.org/comm-central/rev/16d40cae21eb