491936 - Create tests for NetUtil.jsm

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 482310

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

So, this fixes NetUtil.jsm to actually export and contains a test that writes to a file.  The problem being that I'm hitting this assertion and I think the NetUtil code is doing something wrong:
http://mxr.mozilla.org/mozilla-central/source/netwerk/base/src/nsFileStreams.cpp#448

bz - any thoughts/hints?

Comment 2

[Boris Zbarsky [:bzbarsky]]

I think that assertion is bogus and should go away.  In particular, it'll trigger any time someone tests whether the file output stream is buffered!

biesi, any objections to removing those asserts?

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

fair enough. the error return value should be good enough indication.

Comment 4

[Shawn Wilsher :sdwilsh]

Attachment: v1.1

Removing that assertion passes the test :)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 392746 [details] [diff] [review]
v1.1

>+++ b/netwerk/base/src/NetUtil.jsm

Thank you for fixing the obvious errors here!  I have no idea what I was thinking when I wrote that.

>+++ b/netwerk/test/unit/test_NetUtil.js
>+function test_async_write_file()
>+  file.createUnique(Ci.nsIFile.NORMAL_FIEL_TYPE, 0666);

S/FIEL/FILE/, right?

Happened to work because undefined converts to 0, which happens to be NORMAL_FILE_TYPE.

With that fixed, looks good.

Comment 6

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/3ff909687745