NetUtil.asyncCopy does not handle nsISafeOutputStreams correctly

RESOLVED FIXED in mozilla1.9.2b1

Status

()

Core
Networking
RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Tracking

Trunk
mozilla1.9.2b1
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

8 years ago
In order to do this, I'd need to move nsISafeOutputStream into xpcom/io and out of necko.
(Assignee)

Comment 2

8 years ago
Created attachment 392771 [details] [diff] [review]
v1.0

This does the trick, and I'm pretty sure it's right.  I added some comments to make what is going on in nsAStreamCopier::Process a little bit clearer since it wasn't obvious to me what was going on at first.

bsmedberg can review the changes to xpcom/, and bz the unit test I've added in netwerk/.
Attachment #392771 - Flags: review?(bzbarsky)
Attachment #392771 - Flags: review?(benjamin)
(Assignee)

Updated

8 years ago
Whiteboard: [needs review bsmedberg][needs review bz]
Comment on attachment 392771 [details] [diff] [review]
v1.0

r=bzbarsky
Attachment #392771 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

8 years ago
Whiteboard: [needs review bsmedberg][needs review bz] → [needs review bsmedberg]
Attachment #392771 - Flags: review?(benjamin) → review+
(Assignee)

Updated

8 years ago
Whiteboard: [needs review bsmedberg]
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/d9b5c7f26d63
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2b1
(Assignee)

Comment 5

8 years ago
I thought this had passed tests locally, but tinderbox really doesn't like it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

8 years ago
This bug appears to have been wrongfully blamed (and I hadn't backed it out yet).  Closing again.
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Depends on: 1026761
You need to log in before you can comment on or make changes to this bug.