Closed Bug 508605 Opened 11 years ago Closed 11 years ago

NetUtil.asyncCopy does not handle nsISafeOutputStreams correctly

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2b1

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

Details

Attachments

(1 file)

No description provided.
In order to do this, I'd need to move nsISafeOutputStream into xpcom/io and out of necko.
Attached patch v1.0Splinter Review
This does the trick, and I'm pretty sure it's right.  I added some comments to make what is going on in nsAStreamCopier::Process a little bit clearer since it wasn't obvious to me what was going on at first.

bsmedberg can review the changes to xpcom/, and bz the unit test I've added in netwerk/.
Attachment #392771 - Flags: review?(bzbarsky)
Attachment #392771 - Flags: review?(benjamin)
Whiteboard: [needs review bsmedberg][needs review bz]
Comment on attachment 392771 [details] [diff] [review]
v1.0

r=bzbarsky
Attachment #392771 - Flags: review?(bzbarsky) → review+
Whiteboard: [needs review bsmedberg][needs review bz] → [needs review bsmedberg]
Attachment #392771 - Flags: review?(benjamin) → review+
Whiteboard: [needs review bsmedberg]
http://hg.mozilla.org/mozilla-central/rev/d9b5c7f26d63
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2b1
I thought this had passed tests locally, but tinderbox really doesn't like it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This bug appears to have been wrongfully blamed (and I hadn't backed it out yet).  Closing again.
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Depends on: 1026761
You need to log in before you can comment on or make changes to this bug.