491972 - error building SimpleTypeLib.c due to perror() call

Status: VERIFIED FIXED

(Core :: XPCOM, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

On the #WINCE platform, we don't have perror() available to us as seen here:
http://mxr.mozilla.org/mozilla-central/source/xpcom/typelib/xpt/tests/SimpleTypeLib.c#162

and we need to use something like:
fprintf(stderr, "FAILED: fopen");

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Proposed patch

Declare perror with FormatMessage and GetLastError for WINCE.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

If build is successful, the built binary will not work correctly since WINCE needs wmain function.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Thanks for pointing that out.  My initial goal is to get things building, but will need them to run.  I like your approach here to create a stable version of perror(...).

Lets continue with this patch to include the wmain.  I would like to get blassey's feedback on the general approach we should take for wmain.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

(In reply to comment #3)

> Lets continue with this patch to include the wmain.  I would like to get
> blassey's feedback on the general approach we should take for wmain.

IMHO, we should open a new bug about wmain issue for WINCE.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Revised patch

I missed a void.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

we should get this checked in.  Getting the tests to build allows us to test with a lot of other tests.  Fixing the few programs that depend on wmain only limit a few specific tests.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/27d00dddc7d4

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

verified with 1.9.2 build and winmo alpha3