Closed Bug 492192 Opened 11 years ago Closed 11 years ago

Opening local ics files breaks views [Exception in calendar-view-core.xml and calendar-month-view.xml]

Categories

(Calendar :: Calendar Views, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: dbo)

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090509 Calendar/1.0pre

Steps to Reproduce:
1. Start Sunbird with new profile
2. Switch to Month view
3. Download <http://www.mozilla.org/projects/calendar/caldata/GermanHolidays.ics>
4. Download <http://www.mozilla.org/projects/calendar/caldata/USHolidays.ics>
5. Choose File > Open Calendar File and select the 1st .ics file
6. Choose File > Open Calendar File and select the 2nd .ics file

Actual Results:
Not all events are visible in the views. Console errors are listed below.

Expected Results:
All events from both calendars are visible in the views.

Regression range: Works in Sunbird 1.0pre (BuildID: 20090508042346)
                  Fails in Sunbird 1.0pre (BuildID: 20090509045524)

Checkins during regression range: https://hg.mozilla.org/comm-central/pushloghtml?startdate=2009-05-08+04:23:46&enddate=2009-05-09+04:55:24

[[[
Error: item.calendar.name is null
Source File: chrome://calendar/content/calendar-view-core.xml
Line: 243
]]]

[[[
Error: Assert failed: [Exception... "'[JavaScript Error: "item.calendar.name is null" {file: "chrome://calendar/content/calendar-view-core.xml" line: 243}]' when calling method: [calIOperationListener::onGetResult]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///E:/sunbird/components/calCompositeCalendar.js :: anonymous :: line 578"  data: yes]
2: [file:///E:/sunbird/components/calCompositeCalendar.js:440] anonymous
3: [null:0] null
4: [chrome://calendar/content/calendar-task-tree.xml:950] anonymous
5: [chrome://calendar/content/calendar-task-tree.xml:1034] popRefreshQueue
6: [chrome://calendar/content/calendar-task-tree.xml:1047] onOperationComplete
7: [chrome://calendar/content/calendar-task-tree.xml:965] anonymous
8: [null:0] null
9: [file:///E:/sunbird/modules/calProviderUtils.jsm:558] cPB_notifyOperationComplete
10: [file:///E:/sunbird/calendar-js/calMemoryCalendar.js:460] anonymous
11: [null:0] null
]]]

[[[
Error: Assert failed: [Exception... "'[JavaScript Error: "item.calendar.name is null" {file: "chrome://calendar/content/calendar-view-core.xml" line: 243}]' when calling method: [calIOperationListener::onGetResult]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///E:/sunbird/components/calCompositeCalendar.js :: anonymous :: line 578"  data: yes]
2: [file:///E:/sunbird/components/calCompositeCalendar.js:440] anonymous
3: [null:0] null
4: [chrome://calendar/content/calendar-base-view.xml:498] popRefreshQueue
5: [chrome://calendar/content/calendar-base-view.xml:94] onOperationComplete
6: [null:0] null
7: [file:///E:/sunbird/components/calCompositeCalendar.js:496] cancelFunc
8: [file:///E:/sunbird/calendar-js/calUtils.js:1375] calOperationGroup_cancel
9: [null:0] null
10: [chrome://calendar/content/calendar-base-view.xml:451] popRefreshQueue
11: [chrome://calendar/content/calendar-base-view.xml:554] refresh
]]]

[[[
Error: [Exception... "'[JavaScript Error: "itemData.box is undefined" {file: "chrome://calendar/content/calendar-month-view.xml" line: 1041}]' when calling method: [calIAlarmServiceObserver::onRemoveAlarmsByItem]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///E:/sunbird/calendar-js/calUtils.js :: notifyFunc :: line 1231"  data: yes] 
STACK: 
1: [file:///E:/sunbird/calendar-js/calUtils.js:1234] notifyFunc
2: [file:///E:/sunbird/calendar-js/calUtils.js:1237] calListenerBag_notify
3: [file:///E:/sunbird/calendar-js/calAlarmService.js:460] cAS_removeAlarmsForItem
4: [file:///E:/sunbird/calendar-js/calAlarmService.js:541] cAS_fA_onGetResult
5: [null:0] null
6: [file:///E:/sunbird/calendar-js/calMemoryCalendar.js:454] anonymous
7: [null:0] null
8: [file:///E:/sunbird/calendar-js/calICSCalendar.js:502] anonymous
9: [file:///E:/sunbird/calendar-js/calICSCalendar.js:458] anonymous
10: [null:0] null
]]]
Attached patch fix - v1 (obsolete) — Splinter Review
Problem is that quite some place first register the calendar (triggering e.g. load notifications) before having name, color etc set which are queried on load. This patch does not fix Ilja's Problem mentioned in bug 387014.
Assignee: nobody → dbo.moz
Status: NEW → ASSIGNED
Attachment #376784 - Flags: review?(ssitter)
Attached patch fix - v1 sanitized (obsolete) — Splinter Review
I've sanitized the js warning fixes from the previous patch (now attached to bug 492640).
Attachment #376784 - Attachment is obsolete: true
Attachment #376991 - Flags: review?(ssitter)
Attachment #376784 - Flags: review?(ssitter)
Comment on attachment 376784 [details] [diff] [review]
fix - v1

Creating a new profile fails with this patch applied. The main view and calendar list are empty. I could not proceed testing the reported issue. Error Console shows:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIPrefBranch.setCharPref]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: file:///E:/sunbird/calendar-js/calUtils.js :: setPref :: line 524"  data: no]

Error: calendar is null
Source File: chrome://calendar/content/calendar-task-editing.js
Line: 134
Attachment #376784 - Attachment is obsolete: false
Comment on attachment 376991 [details] [diff] [review]
fix - v1 sanitized

I get the same error as mentioned in comment #3 with the previous patch.
Attachment #376991 - Flags: review?(ssitter) → review-
Attached patch fix - v2Splinter Review
Attachment #376784 - Attachment is obsolete: true
Attachment #376991 - Attachment is obsolete: true
Attachment #377002 - Flags: review?(ssitter)
Comment on attachment 377002 [details] [diff] [review]
fix - v2

r=ssitter
Attachment #377002 - Flags: review?(ssitter) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/8d3b009b43d7>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
OS: Windows XP → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090611 Calendar/1.0pre (BuildID: 20090611031611)
Status: RESOLVED → VERIFIED
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.