492231 - Inconsistent bidi with dynamic "direction: rtl;" on iso-8859-8 (visual order) page

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jesse Ruderman]

Attachment: testcase (dynamic)

The testcase and reference have the same final DOM, so they should look the same.

This bug only happens with the iso-8859-8 charset, so I suspect it has something to do with the "mIsVisual" member of nsPresContext being set to true.

Comment 1

[Jesse Ruderman]

Attachment: reference (static)

Comment 2

[Simon Montagu :smontagu]

Attachment: Patch

This was exposed by bug 332655, but it's really a consequence of special casing frame placement for visual RTL instead of using the regular bidi frame reordering code.

Comment 3

[Simon Montagu :smontagu]

http://hg.mozilla.org/mozilla-central/rev/a7d85f591248

Comment 4

[Daniel Holbert [:dholbert]]

This checkin introduced one new warning:
  mozilla/layout/generic/nsLineLayout.cpp:2488: warning: unused variable ‘maxX’
due to removing all uses of 'maxX' without removing the variable declaration.

Can we remove the declaration for this now-unused variable in a followup patch, to fix this warning?

Comment 5

[Simon Montagu :smontagu]

Attachment: Fix warning

Thanks for catching that! Removing the declaration allows some further code simplification.

Comment 6

[Simon Montagu :smontagu]

Fix for the warning checked in in http://hg.mozilla.org/mozilla-central/rev/61b4f75f175a

Comment 7

[Simon Montagu :smontagu]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/5ba8ffa2d6dd