Closed Bug 492476 Opened 16 years ago Closed 15 years ago

[MacOSX] mochitest-chrome: the 3 layout/base/tests/test_printpreview*.xul need to report 'todo'

Categories

(Core :: Printing: Output, defect)

Product:
Core
Component:
Printing: Output
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.3a5
Tracking Flags:
Tracking Status
status1.9.2 --- .5-fixed
status1.9.1 --- .10-fixed

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(
URL
)

Details

Attachments

(1 file)

(Av1) Remove useless |var printerEnumerator|, Use a todo() [Checkin: See comment 8 & 11]
4.20 KB, patch
roc
: review+
Details | Diff | Splinter Review
{ http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1242092605.1242096280.17513.gz&fulltext=1 OS X 10.5.2 mozilla-central unit test on 2009/05/11 18:43:25 *** 43086 INFO Running /tests/layout/base/tests/test_bug396024.html... *** 43087 INFO TEST-KNOWN-FAIL | /tests/layout/base/tests/test_bug396024.html | [SimpleTest.report()] No checks actually run. } See http://hg.mozilla.org/mozilla-central/rev/b3d077ffddbd
Same with { *** 43515 INFO Running /tests/layout/base/tests/test_bug482976.html... *** 43516 INFO TEST-KNOWN-FAIL | /tests/layout/base/tests/test_bug482976.html | [SimpleTest.report()] No checks actually run. }
Depends on: 482976
Summary: [MacOSX] mochitest-plain: layout/base/tests/test_bug396024.html needs to report success → [MacOSX] mochitest-plain: layout/base/tests/test_bug396024.html and /test_bug482976.html need to report success
Same with { *** 43526 INFO Running /tests/layout/base/tests/test_printpreview.html... *** 43527 INFO TEST-KNOWN-FAIL | /tests/layout/base/tests/test_printpreview.html | [SimpleTest.report()] No checks actually run. } blamed to restricted access bugs: bug 425265, bug 424377.
Summary: [MacOSX] mochitest-plain: layout/base/tests/test_bug396024.html and /test_bug482976.html need to report success → [MacOSX] mochitest-plain: layout/base/tests/test_bug396024.html, /test_bug482976.html and test_printpreview.html need to report success
The Mac platform doesn't have the print preview code necessary for it to work. That might be a bug, I think I've seen a bug floating around about that. So I guess it might need to report todo perhaps.
(In reply to comment #3) > That might be a bug, I think I've seen a bug floating around about that. Bug 347417 ;-) > So I guess it might need to report todo perhaps. Agreed.
Depends on: 347417
Hardware: x86 → All
Summary: [MacOSX] mochitest-plain: layout/base/tests/test_bug396024.html, /test_bug482976.html and test_printpreview.html need to report success → [MacOSX] mochitest-plain: layout/base/tests/test_bug396024.html, /test_bug482976.html and test_printpreview.html need to report 'todo'
(In reply to comment #4) > (In reply to comment #3) > > That might be a bug, I think I've seen a bug floating around about that. > > Bug 347417 ;-) I'm not sure it's that bug. That bug seems to talk about a print preview menu-item, it doesn't seem to explicitly mention about the desire to have webBrowserPrint.printPreview implemented on the Mac.
No longer blocks: 483407
Depends on: 483407
Summary: [MacOSX] mochitest-plain: layout/base/tests/test_bug396024.html, /test_bug482976.html and test_printpreview.html need to report 'todo' → [MacOSX] mochitest-chrome: layout/base/tests/test_bug396024.html, /test_bug482976.html and test_printpreview.html need to report 'todo'
Summary: [MacOSX] mochitest-chrome: layout/base/tests/test_bug396024.html, /test_bug482976.html and test_printpreview.html need to report 'todo' → [MacOSX] mochitest-chrome: the 3 layout/base/tests/test_printpreview*.xul need to report 'todo'
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #438666 - Flags: review?(roc)
Comment on attachment 438666 [details] [diff] [review] (Av1) Remove useless |var printerEnumerator|, Use a todo() [Checkin: See comment 8 & 11] http://hg.mozilla.org/mozilla-central/rev/058b1d064f88
Attachment #438666 - Attachment description: (Av1) Remove useless |var printerEnumerator|, Use a todo() → (Av1) Remove useless |var printerEnumerator|, Use a todo() [Checkin: Comment 8]
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
(In reply to comment #8) + http://hg.mozilla.org/mozilla-central/rev/22df6c8c783a (Bv1) Add missed |var todo = window.opener.wrappedJSObject.todo;|.
Blocks: 396024, 482976
No longer depends on: 396024, 482976
Blocks: 556686
V.Fixed per tinderboxes.
Status: RESOLVED → VERIFIED
Comment on attachment 438666 [details] [diff] [review] (Av1) Remove useless |var printerEnumerator|, Use a todo() [Checkin: See comment 8 & 11] http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9196d70fd5e5 including (In reply to comment #9) > http://hg.mozilla.org/mozilla-central/rev/22df6c8c783a > (Bv1) Add missed |var todo = window.opener.wrappedJSObject.todo;|.
Attachment #438666 - Attachment description: (Av1) Remove useless |var printerEnumerator|, Use a todo() [Checkin: Comment 8] → (Av1) Remove useless |var printerEnumerator|, Use a todo() [Checkin: See comment 8 & 11]
status1.9.2: --- → .5-fixed
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3eab3c816d4e (Cv1-191) Remove useless |var printerEnumerator|, Use a todo().
status1.9.1: --- → .10-fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: