492477 - mochitest-plain: toolkit/components/alerts/test/test_alerts.html needs to report success

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Serge Gautherie (:sgautherie)]

{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1242092605.1242096280.17513.gz&fulltext=1
OS X 10.5.2 mozilla-central unit test on 2009/05/11 18:43:25

*** 75247 INFO Running /tests/toolkit/components/alerts/test/test_alerts.html...
*** 75248 INFO TEST-KNOWN-FAIL | /tests/toolkit/components/alerts/test/test_alerts.html | [SimpleTest.report()] No checks actually run.
}

Comment 1

[Michael Ventnor]

This is simple, the test boxes don't have Growl installed so there is no alerts system to test.
The solution would to a) install Growl and make sure it is always running, b) insert a tautology into the test or c) just ignore it.

Comment 2

[Serge Gautherie (:sgautherie)]

b- An ok(true, "No installed Growl to test") (or a todo(false, ...)) would be fine.

Comment 3

[Dão Gottwald [:dao]]

(In reply to comment #1)
> This is simple, the test boxes don't have Growl installed so there is no alerts
> system to test.

Do you know why we're not falling back to the custom implementation?

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> Do you know why we're not falling back to the custom implementation?

No answer in 5.5 months:
question copied to (related!?) bug 611540 comment 7.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> (In reply to comment #3)
> > Do you know why we're not falling back to the custom implementation?
> 
> question copied to (related!?) bug 611540 comment 7.

I eventually filed bug 612411.