Closed
Bug 492485
Opened 16 years ago
Closed 16 years ago
Missing attachment check should only look at text, not element names and attribute names and values
Categories
(Thunderbird :: Message Compose Window, defect)
Thunderbird
Message Compose Window
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: JoeS1, Assigned: philor)
References
Details
Attachments
(1 file)
|
1009 bytes,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
If an image is embedded inline, the source is misinterpreted as a missing attachment.
Examples for img src:
mailbox:///C|/Documents%20and%20Settings/
file:///C:/doc/1h.gif
|
||
Updated•16 years ago
|
Flags: blocking-thunderbird3+
|
Assignee | |
Comment 1•16 years ago
|
||
Those aren't very durable examples, since they're both depending on the separate bug that we're using unescaped dots in regexps, but we also shouldn't find src="file:///attachment/foo" or for that matter alt="attachment,attached,.doc,.pdf,resume,cover letter".
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #376857 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Updated•16 years ago
|
OS: Windows XP → All
Hardware: x86 → All
Summary: IMG source data is falsely detected as a missing attachment → Missing attachment check should only look at text, not element names and attribute names and values
Target Milestone: --- → Thunderbird 3.0b3
|
||
Comment 2•16 years ago
|
||
Comment on attachment 376857 [details] [diff] [review]
Use .textContent
Doh! r=mkmelin
Attachment #376857 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•