492659 - Double unlock in js_SetProtoOrParent

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Igor Bukanov]

As a result of my changes for the bug #489501 js_SetProtoOrParent from jsobj.cpp now contains:

  JS_UNLOCK_OBJ(cx, obj);
  bool ok = !!js_GetMutableScope(cx, obj);
  JS_UNLOCK_OBJ(cx, obj);
  
instead of intended LOCK/UNLOCK pair. Note that it was really hard to sport this when checking the patch, so all blame goes on myself. This resulted in the mochi test faulires with a debug build, see bug 465131 comment 1.

Comment 1

[Igor Bukanov]

Nominating for 1.9.1 as this is a regression from a 1.9.1 blocker.

Comment 2

[Igor Bukanov]

Attachment: fix

changing the code to use the intended LOCK/UNLOCK pair

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 377023 [details] [diff] [review]
fix

IMO patches this simple shouldn't require review.

Comment 4

[Igor Bukanov]

(In reply to comment #3)
> IMO patches this simple shouldn't require review.

Sorry for the review spam - for me the time it takes to follow the procedure is a very good remainder that should help not do such stupid bugs in the future.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Don't worry about it. I wasn't complaining to you. I know the feeling of trying to work too fast (and wasting a bunch of time as a result)!

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/9caa852c758c

Comment 7

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/0076fe7236b6