493173 - Download Manager gets stuck in customize toolbar mode when auto-closed with sheet open

Status: RESOLVED FIXED

(Camino Graveyard :: Downloading, defect)

Description

[Lisa Thompson]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en; rv:1.9.0.11pre) Gecko/2009051413 Camino/2.0b3pre (like Firefox/3.0.11pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en; rv:1.9.0.11pre) Gecko/2009051413 Camino/2.0b3pre (like Firefox/3.0.11pre)

This is a dupe of Bug 283359, but that bug is old and fixed so I wasn't sure whether to post there or file anew; sorry if I chose wrong.

Steps to Reproduce:
1. In Downloads prefs, check "Close Downloads window".
2. Begin a download.
3. Right-click on the Download Manager toolbar and choose "Customize Toolbar..."
4. Wait for the download to finish; the Download Manager will close automatically even though the customize sheet is still open.
5. Re-open the Download Manager.
3. Right-click on the toolbar and choose "Customize Toolbar..."

Actual Results:  
Nothing happens, no customize sheet appears. Moreover, you can see the spacers and drag the toolbar icons as if in customize mode. I could find no way to get out of this except to quit and re-launch.

Expected Results:  
The Download Manager should either stay open and allow you to finish customizing the toolbar, or it should cancel customize mode before auto-closing so the window is normal when re-opened.

I see this issue in 1.6.7, 2.0b2, and recent nightly, all tested with fresh profile. I'm using Leopard 10.5.7.

Reproducible: Always

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

If a fixed bug is more than a couple weeks to a couple months old, it's always best to file anew ;)

(I haven't had a chance to look at this myself, so not setting to NEW yet, but it certainly sounds like something that could have regressed in the past 4 years.)

Comment 2

[Ilya Sherman]

Attachment: Fix

Comment 3

[Stuart Morgan]

Comment on attachment 377820 [details] [diff] [review]
Fix

sr=smorgan

At least we regressed it for a good reason ;)

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on cvs trunk.

I'm not sure how common this is, but the fix looks simple enough, so maybe we want it for 1.6.8, too?

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the MOZILLA_1_8_BRANCH in advance of 1.6.8.