Last Comment Bug 493202 - Add a hidden pref to control the CSS-pixel-to-dev-pixel ratio
: Add a hidden pref to control the CSS-pixel-to-dev-pixel ratio
Status: RESOLVED FIXED
: fixed1.9.1
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: All All
: -- normal with 1 vote (vote)
: ---
Assigned To: Robert O'Callahan (:roc) (Exited; email my personal email if necessary)
:
Mentors:
: 424822 (view as bug list)
Depends on:
Blocks: 513439
  Show dependency treegraph
 
Reported: 2009-05-15 04:09 PDT by Robert O'Callahan (:roc) (Exited; email my personal email if necessary)
Modified: 2009-10-08 06:09 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (9.88 KB, patch)
2009-05-15 04:42 PDT, Robert O'Callahan (:roc) (Exited; email my personal email if necessary)
vladimir: review+
mbeltzner: approval1.9.1+
Details | Diff | Splinter Review

Description Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2009-05-15 04:09:22 PDT
See https://bugzilla.mozilla.org/show_bug.cgi?id=394103#c53. XO needs this.
Comment 1 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2009-05-15 04:42:21 PDT
Created attachment 377661 [details] [diff] [review]
fix

Straightforward.
Comment 2 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2009-05-17 18:13:31 PDT
http://hg.mozilla.org/mozilla-central/rev/9ba7c1e36fe9
Comment 3 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2009-05-17 18:14:45 PDT
Comment on attachment 377661 [details] [diff] [review]
fix

I would actually like to take this on 1.9.1. The patch is small and fairly safe. Exposing this pref would be useful to the OLPC people and probably other users.
Comment 4 David Baron :dbaron: ⌚️UTC+2 (review requests must explain patch) 2009-05-18 16:59:45 PDT
Comment on attachment 377661 [details] [diff] [review]
fix

>diff --git a/modules/libpref/src/init/all.js b/modules/libpref/src/init/all.js
>+// Override DPI. A value of -1 means use the minimum of 96 and the system DPI.

Shouldn't this say "maximum" rather than "minimum"?
Comment 5 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2009-05-18 17:14:24 PDT
Yes it should.
Comment 6 Serge Gautherie (:sgautherie) 2009-05-18 19:13:51 PDT
(In reply to comment #5)
> Yes it should.

You checked in 'maxium' :-/
Comment 7 Mike Beltzner [:beltzner, not reading bugmail] 2009-05-19 13:00:37 PDT
Comment on attachment 377661 [details] [diff] [review]
fix

a191, but fix the spelling error?
Comment 8 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2009-05-20 16:28:06 PDT
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/761c10686403
Comment 9 Sylvain Pasche 2009-06-23 03:10:48 PDT
*** Bug 424822 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.