49331 - Search/Find text "Match upper/lower case" is ambiguous

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Mike Coleman]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.4.0-test1 i686; en-US; m17) Gecko/20000807
BuildID:    2000080712

The text for the the Search/Find dialog is ambiguous, to me at least.  "Match
upper/lower case" suggests either that upper must match upper and lower must
match lower (case sensitive) or that characters typed in will match upper or
lower (case insensitive).

Reproducible: Always
Steps to Reproduce:
1.Look
2.
3.

Expected Results:  Maybe just say "case sensitive?"

Comment 1

[Matthew T (active 1999-2002)]

In the future, hopefully we will have stuff for matching diacritics and all sorts 
of other minor variants of characters which occur in particular writing systems. 
So whatever we do should be forwards-compatible if possible. I suggest `Exact 
case' (see bug 7930).

Comment 2

[leger]

Reassigning from bdonohoe to hangas

Comment 3

[Oliver Klee]

From bug 66696:

"match upper/lower case" is ambiguous because it suggests that _either_ could be
matched. a much more concise way of saying "case sensitive" would be "match case".

Comment 4

[John Morrison]

*** Bug 66696 has been marked as a duplicate of this bug. ***

Comment 5

[Zach Lipton [:zach]]

Chaning the qa contact on these bugs to me. MPT will be moving to the 
owner of this component shortly. I would like to thank him for all his hard 
work as he moves roles in mozilla.org...Yada, Yada, Yada...

Comment 6

[Asa Dotzler [:asa]]

updating to new owner. sorry for the spam.

Comment 7

[Jerome Lacoste]

Suggest to move OS field from Linux to all.

Furthermore I am not sure that the dependency on 7930 is true. I think the bug
can be fixed without fixing the other one. Can this be checked?

This seems like a trivial bug that could be quickly corrected.
Today, there are only 7 references to upper/lower, as shown by this URL
http://lxr.mozilla.org/seamonkey/search?string=upper%2Flower

http://lxr.mozilla.org/seamonkey/source/extensions/help/resources/locale/en-US/composer_help.html#318
http://lxr.mozilla.org/seamonkey/source/extensions/help/resources/locale/en-US/composer_help.html#335
http://lxr.mozilla.org/seamonkey/source/extensions/help/resources/locale/en-US/nav_help.html#555
http://lxr.mozilla.org/seamonkey/source/xpfe/components/find/resources/locale/en-US/finddialog.dtd#6
http://lxr.mozilla.org/seamonkey/source/xpfe/components/find/resources/locale/en-US/replacedialog.dtd#6
http://lxr.mozilla.org/seamonkey/source/l10n/langpacks/en-DE/chrome/en-DE/global/locale/finddialog.dtd#5
http://lxr.mozilla.org/seamonkey/source/l10n/langpacks/en-GB/chrome/en-GB/global/locale/finddialog.dtd#5

But I guess that there may be other locales to fix and/pr that the search I've
done on LXR may bot be perfect.

Comment 8

[Colin Slater]

Attachment: Chang text to "Match Exact Case"

Changes text to "Match Exact Case" for both the find and find&replace dialogs.
Only works for en-US. I think the rest is up to the localization people.

Comment 9

[Colin Slater]

Attachment: Change text to "Match Exact Case", most everywhere.

Ahh, I didn't see what you meant in the last post. This patch changes the text
for all of those locations, except for the non-en-US ones. Sorry `bout that.

Comment 10

[Jerome Lacoste]

I like it! Perhaps need review?
BTW what about the dependency?

Comment 11

[Colin Slater]

I think that the dependency is sora unrelated, that this will fix this current
dialog, and if they redo the dialog, they can still use this patch, I guess, I
only changed DTD's and help files.

If someone special could check this out i'd be very nice. There's not alot to
review, no code, it's mostly just a matter of if it should be changed or not.

Comment 12

[Jonas Jørgensen]

.

Comment 13

[Ryan Grove]

This bug has existed for nearly three years now, with a year-old patch that
hasn't been accepted, and this still trips me up whenever I need to search for
something. What's the status on this thing?

Comment 14

[Aaron Brick]

(In reply to comment #13)

incredible. it seems so trivial.

Comment 15

[Stef Van Vlierberghe]

(In reply to comment #14)
> (In reply to comment #13)
> 
> incredible. it seems so trivial.

I just got confused by this too, and wanted to file a bug report, but found out the deficiency is already known since 5 years. FC4 Mozilla 1.7.10 still shows Match upper/lower case, which I interpreted as upper OR lower case. A bit of a sad story.

Comment 16

[Wayne Mery (:wsmwk)]

does a language issue need to be addressed?
line numbers for patch attachment 59217 [details] [diff] [review] have changed except for finddialog.dtd
patch author Colin is not reachable

Comment 17

[Andrew Schultz]

Attachment: updated patch

toolkit find dialog just says "Match case"

Comment 18

[Andrew Schultz]

FIXED