493560 - Upgrade to SQLite 3.6.14.2

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Shawn Wilsher :sdwilsh]

+++ This bug was initially created as a clone of Bug #489442 +++

We'll be taking a special branch containing two fixes - one we need, and one recommended by the SQLite folks.

Fixes this will contain on top of 3.6.14:
http://www.sqlite.org/cvstrac/tktview?tn=3841 (we need this one for places)
http://www.sqlite.org/cvstrac/tktview?tn=3844 (suggested that we take this)

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

I've pushed this to the try server to verify that there are no performance regressions or unit test regressions.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Are the SQLite folks going to officially release 3.6.14.1?  It is not public/visible on their site currently.  If not, how are distributions that build using system SQLite supposed to meet the configure requirement?

Comment 3

[Shawn Wilsher :sdwilsh]

It's still in QA on their end - we are working in parallel (and I obviously won't land this until they give me the all clear).

Comment 4

[Shawn Wilsher :sdwilsh]

Looks OK on the try server (one known random orange did happen on windows, so I'm running it again).

Still waiting for the SQLite folks to sign off.

Comment 5

[Shawn Wilsher :sdwilsh]

Got the all clear last night, and it's been released on the SQLite website.

Comment 6

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/dd3d70e5849e
http://hg.mozilla.org/mozilla-central/rev/4480c18255f2

Comment 7

[Shawn Wilsher :sdwilsh]

Comment on attachment 378071 [details] [diff] [review]
v1.0

I'd really like to get this on 1.9.1 so that we can bumb the min-version of SQLite so folks don't try to ship with a known-bad system SQLite.  It'll also fix the two bugs this blocks on branch, as well as get us some minor performance and stability wins (we were previously on 3.6.10).

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Needs more baking before we'd take it on 191

Comment 9

[Shawn Wilsher :sdwilsh]

(In reply to comment #8)
> Needs more baking before we'd take it on 191
Right, I don't expect approval today.

Comment 10

[Jim Jeffery not reading bug-mail 1/2/11]

This was backed out with changeset: 
http://hg.mozilla.org/mozilla-central/rev/cc61db43d445

Shouldn't this be re-opened ?

Comment 11

[Shawn Wilsher :sdwilsh]

(In reply to comment #10)
> Shouldn't this be re-opened ?
Yes, this was backed out because it was thought to have caused orange on the tree.  It turns out it wasn't the culprit.  I was going to land this this morning, but now the tree is closed and only accepting blockers, so it looks like this won't make 1.9.1 :(

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 378071 [details] [diff] [review]
v1.0

Needs to bake on trunk before we would consider it.

Comment 13

[Shawn Wilsher :sdwilsh]

Comment on attachment 378071 [details] [diff] [review]
v1.0

So, this can't land on 1.9.1 because it hasn't landed on mozilla-central and baked.  I can't land it on mozilla-central unless I get approval for 1.9.1.  I'm requesting approval in order to get it on mozilla-central, where we can then evaluate if we want it for 1.9.1.

Comment 14

[Hiroyuki Ikezoe (:hiro)]

Shawn, can you push the new SQLite into mozilla-central without approval for 1.9.1?

This upgrade fixes bug 489589 anyway. If new other bugs will be introduced by upgrading, I will try fix it.

Comment 15

[Shawn Wilsher :sdwilsh]

(In reply to comment #14)
> Shawn, can you push the new SQLite into mozilla-central without approval for
> 1.9.1?
> 
> This upgrade fixes bug 489589 anyway. If new other bugs will be introduced by
> upgrading, I will try fix it.
Not per tree rules right now, unless those have changed without my knowledge.

Comment 16

[Shawn Wilsher :sdwilsh]

SQLite just released a new version for a bug fix that we are highly unlikely to hit.  This is version 3.6.14.2, so I'm updating the patches for this bug.  I pushed this to the try server to make sure all is good (things look good locally).

The change in question is http://www.sqlite.org/cvstrac/tktview?tn=3879

Comment 17

[Shawn Wilsher :sdwilsh]

Attachment: v2.0

This shouldn't need a new review.

Comment 18

[Hiroyuki Ikezoe (:hiro)]

I confirmed version 3.6.14.2 fixed bug 489589.

Comment 19

[Shawn Wilsher :sdwilsh]

I am sufficient convinced that this isn't going to cause any problems based on a few try server runs.

Comment 20

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/77f92242f164
http://hg.mozilla.org/mozilla-central/rev/11e357b100c0

Comment 21

[Jesse Ruderman]

Taking this on 1.9.1 would fix the #20 topcrash (bug 503770).

Comment 22

[Nochum Sossonko [:Natch]]

Bug 508104 is the one Shawn is trying to land on 1.9.1.

Comment 23

[Shawn Wilsher :sdwilsh]

In fact, I'd rather take bug 508104 because we've at least shipped an alpha with it.  We didn't ship anything but nightlies with this release.